Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upstatic function overhaul #3538
Closed
static function overhaul #3538
Conversation
bagder
force-pushed the
bagder/static-singleuse
branch
4 times, most recently
from
624fce4
to
6c8ee6f
This comment has been minimized.
This comment has been minimized.
|
Running the script automatically in travis is probably far too troublesome due to all the various special builds we have. I'll just add the script for manual use. |
urlapi: turn three local-only functions into statics conncache: make conncache_find_first_connection static multi: make detach_connnection static connect: make getaddressinfo static curl_ntlm_core: make hmac_md5 static http2: make two functions static http: make http_setup_conn static connect: make tcpnodelay static tests: make UNITTEST a thing to mark functions with, so they can be static for normal builds and non-static for unit test builds ... and mark Curl_shuffle_addr accordingly. url: make up_free static setopt: make vsetopt static curl_endian: make write32_le static rtsp: make rtsp_connisdead static warnless: remove unused functions memdebug: remove one unused function, made another static
That is functions that are declared global but are not used from outside of the file in which it is declared. Such functions should be made static or even at times be removed. It also verifies that all used curl_ prefixed functions are "blessed"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bagder commentedFeb 8, 2019
•
edited
Here's a script to
curl_- prefix without being part of the public API... and the associated changes to a bunch of files to cleanup all issues the script detected. I'll subsequently have a go and see if I can add the script to one or more of the travis builds to make sure we detect these mistakes/optimizations before they land.
(I intend so squash all these into a single commit for the changes and one for the script before merging)