Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate fish completion file #3545

Closed
wants to merge 4 commits into from

Conversation

@simon04
Copy link
Contributor

commented Feb 10, 2019

scripts/zsh.pl Outdated Show resolved Hide resolved
scripts/zsh.pl Outdated Show resolved Hide resolved
FISH_FUNCTIONS_DIR="$withval"
AC_SUBST(FISH_FUNCTIONS_DIR)
;;
esac

This comment has been minimized.

Copy link
@danielgustafsson

danielgustafsson Feb 10, 2019

Member

This will get unwieldy when the third and fourth and .. and ... shell gets added. Is there a way to support the tab completion with a single configure flag invocation? --with-shell-functions={fish|zsh}?

This comment has been minimized.

Copy link
@simon04

simon04 Feb 10, 2019

Author Contributor

Maybe someone else with a better understanding of the build system (than me) can investigate (later on)?

This comment has been minimized.

Copy link
@danielgustafsson

danielgustafsson Feb 13, 2019

Member

Yes, this can be deferred, potentially till when we want to add a third tab completion target even.

@bagder
bagder approved these changes Feb 12, 2019
Copy link
Member

left a comment

Looks good to me!

@bagder

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

The appveyor fail looks totally unrelated - I just won't retrigger a rebuild now because appveyor seems to be awefully slow at the moment so it'll just add many pointless hours of waiting.

FISH_FUNCTIONS_DIR="$withval"
AC_SUBST(FISH_FUNCTIONS_DIR)
;;
esac

This comment has been minimized.

Copy link
@danielgustafsson

danielgustafsson Feb 13, 2019

Member

Yes, this can be deferred, potentially till when we want to add a third tab completion target even.

if ($shell eq 'fish') {
print "# curl fish completion\n\n";
print qq{$_ \n} foreach (@opts);
} elsif ($shell eq 'zsh') {

This comment has been minimized.

Copy link
@danielgustafsson

danielgustafsson Feb 13, 2019

Member

This seems to lack an else case erroring out when the shell has been specified to an incorrect value.

This comment has been minimized.

Copy link
@bagder

bagder Feb 21, 2019

Member

@simon04, any thoughts on this nit?

@simon04

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

@bagder

This comment has been minimized.

Copy link
Member

commented Mar 2, 2019

Thanks!

@bagder bagder closed this in e075b21 Mar 2, 2019

@eli-schwartz

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

For the record... #3723

Fish has a special directory for completions that are installed by thirdparty software and not by fish itself. There is also a pkg-config file to detect that directory.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.