cookie: Add support for cookie prefixes #3554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgustafsson
force-pushed
the
dg-cookie_prefixes
branch
from
a4753a9
to
dd8f9df
Compare
The draft-ietf-httpbis-cookie-prefixes-00 draft, which has been adopted by the major browsers, specify a set of prefixes and how they should affect cookie initialization. This adds support for the two prefixes defined, __Host- and __Secure and updates the testcase with the supplied examples from the draft. Closes #xxxx
danielgustafsson
force-pushed
the
dg-cookie_prefixes
branch
from
dd8f9df
to
b91f380
Compare
bagder
approved these changes
Feb 11, 2019
|
BTW, it seems the cookie prefix draft was adopted in to the rfc6265bis work so the latest one is probably this: https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02 |
Nice catch, so it did. Will update the PR referencing that one instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The draft-ietf-httpbis-cookie-prefixes-00 draft, which has been adopted by the major browsers, specify a set of prefixes and how they should affect cookie initialization. This adds support for the two prefixes defined,
__Host-and__Secure-and updates the testcase with the supplied examples from the draft.