Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisescookie: Add support for cookie prefixes #3554
+73
−13
Conversation
danielgustafsson
force-pushed the
danielgustafsson:dg-cookie_prefixes
branch
from
a4753a9
to
dd8f9df
Feb 11, 2019
danielgustafsson
force-pushed the
danielgustafsson:dg-cookie_prefixes
branch
from
dd8f9df
to
b91f380
Feb 11, 2019
bagder
approved these changes
Feb 11, 2019
This comment has been minimized.
This comment has been minimized.
|
BTW, it seems the cookie prefix draft was adopted in to the rfc6265bis work so the latest one is probably this: https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02 |
This comment has been minimized.
This comment has been minimized.
Nice catch, so it did. Will update the PR referencing that one instead. |
danielgustafsson
closed this
in
e652252
Feb 16, 2019
lock
bot
locked as resolved and limited conversation to collaborators
May 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
danielgustafsson commentedFeb 11, 2019
The draft-ietf-httpbis-cookie-prefixes-00 draft, which has been adopted by the major browsers, specify a set of prefixes and how they should affect cookie initialization. This adds support for the two prefixes defined,
__Host-and__Secure-and updates the testcase with the supplied examples from the draft.