travis: add scan-build #3564
Closed
travis: add scan-build #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/travis-scan-build
branch
from
cd3c5ac
to
53deb6e
Compare
scan-build warning: Null pointer passed as an argument to a 'nonnull' parameter
in ftpget, ftpsget and sftpget, so that scan-build stops warning for potential NULL pointer dereference below! Detected by scan-build
Detected by scan-build
…memory' Detected by scan-build
To avoid scan-build warnings and global variables.
Fix scan-build warnings, no globals, no silly handle scan. Also remove handles from the multi before cleaning up.
Detected by scan-build
bagder
force-pushed
the
bagder/travis-scan-build
branch
from
53deb6e
to
096c8e5
Compare
|
what is up with the CIs failing most of the time that is much more frequent than it used to be, is there anything we can do about that or is it all in the hands of travis/appveyor/etc |
|
With the increase in number of CI builds I suppose the risk for fails increase. We have problems with false test failures in appveyor, travis test build time-outs (they then typically fail without even starting) and other occasional hiccups. I don't have any particular good ideas on what we can do to improve this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Here's a new take at adding a scan-build run to travis. scan-build generally have the downside that it is very annoying when it happens to trigger false positives. But it does point out flaws every now and then and clearly the tidy target is not as picky.