Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: add scan-build #3564

Closed
wants to merge 8 commits into from

Conversation

@bagder
Copy link
Member

commented Feb 13, 2019

Here's a new take at adding a scan-build run to travis. scan-build generally have the downside that it is very annoying when it happens to trigger false positives. But it does point out flaws every now and then and clearly the tidy target is not as picky.

@bagder bagder added the build label Feb 13, 2019

@bagder bagder force-pushed the bagder/travis-scan-build branch from cd3c5ac to 53deb6e Feb 14, 2019

bagder added 8 commits Nov 20, 2017
strip_trailing_dot: make sure NULL is never used for strlen
scan-build warning: Null pointer passed as an argument to a 'nonnull'
parameter
examples: remove superfluous null-pointer checks
in ftpget, ftpsget and sftpget, so that scan-build stops warning for
potential NULL pointer dereference below!

Detected by scan-build
examples/http2-download: cleaned up
To avoid scan-build warnings and global variables.
examples/http2-upload: cleaned up
Fix scan-build warnings, no globals, no silly handle scan. Also remove
handles from the multi before cleaning up.

@bagder bagder force-pushed the bagder/travis-scan-build branch from 53deb6e to 096c8e5 Feb 14, 2019

@bagder bagder closed this in 8ae3db5 Feb 14, 2019

@bagder bagder deleted the bagder/travis-scan-build branch Feb 14, 2019

@jay

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

what is up with the CIs failing most of the time that is much more frequent than it used to be, is there anything we can do about that or is it all in the hands of travis/appveyor/etc

@bagder

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2019

With the increase in number of CI builds I suppose the risk for fails increase. We have problems with false test failures in appveyor, travis test build time-outs (they then typically fail without even starting) and other occasional hiccups. I don't have any particular good ideas on what we can do to improve this. ☹️

@lock lock bot locked as resolved and limited conversation to collaborators May 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.