New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: add scan-build #3564
travis: add scan-build #3564
Conversation
cd3c5ac
to
53deb6e
Compare
scan-build warning: Null pointer passed as an argument to a 'nonnull' parameter
in ftpget, ftpsget and sftpget, so that scan-build stops warning for potential NULL pointer dereference below! Detected by scan-build
Detected by scan-build
…memory' Detected by scan-build
To avoid scan-build warnings and global variables.
Fix scan-build warnings, no globals, no silly handle scan. Also remove handles from the multi before cleaning up.
Detected by scan-build
53deb6e
to
096c8e5
Compare
what is up with the CIs failing most of the time that is much more frequent than it used to be, is there anything we can do about that or is it all in the hands of travis/appveyor/etc |
With the increase in number of CI builds I suppose the risk for fails increase. We have problems with false test failures in appveyor, travis test build time-outs (they then typically fail without even starting) and other occasional hiccups. I don't have any particular good ideas on what we can do to improve this. |
Here's a new take at adding a scan-build run to travis. scan-build generally have the downside that it is very annoying when it happens to trigger false positives. But it does point out flaws every now and then and clearly the tidy target is not as picky.