Skip to content

unit1307: require FTP support - #3565

Closed
MarcelRaad wants to merge 1 commit into
curl:masterfrom
MarcelRaad:unit1307_without_ftp
Closed

unit1307: require FTP support#3565
MarcelRaad wants to merge 1 commit into
curl:masterfrom
MarcelRaad:unit1307_without_ftp

Conversation

@MarcelRaad

@MarcelRaad MarcelRaad commented Feb 13, 2019

Copy link
Copy Markdown
Member

This test doesn't link after fc7ab48,
which made Curl_fnmatch unavailable without FTP support.

@MarcelRaad
unit1307: require FTP support
93d90ec 
This test doesn't link after fc7ab48,
which made Curl_fnmatch unavailable without FTP support.
@MarcelRaad

MarcelRaad commented Feb 13, 2019

Copy link
Copy Markdown
Member Author

See today's autobuilds:
https://curl.haxx.se/dev/log.cgi?id=20190213054353-30171
https://curl.haxx.se/dev/log.cgi?id=20190213051733-5794

bagder
bagder approved these changes Feb 13, 2019
View reviewed changes

@bagder bagder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice catch. Thanks!

@MarcelRaad
MarcelRaad deleted the unit1307_without_ftp branch February 13, 2019 07:46
@MarcelRaad

MarcelRaad commented Feb 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

The AppVeyor HTTP-only job should have caught this, but...

The project "unit1300" is not selected for building in solution configuration "Debug|x64".
The project "unit1301" is not selected for building in solution configuration "Debug|x64".
The project "unit1302" is not selected for building in solution configuration "Debug|x64".
The project "unit1303" is not selected for building in solution configuration "Debug|x64".
The project "unit1304" is not selected for building in solution configuration "Debug|x64".
The project "unit1305" is not selected for building in solution configuration "Debug|x64".
The project "unit1307" is not selected for building in solution configuration "Debug|x64".
The project "unit1308" is not selected for building in solution configuration "Debug|x64".
The project "unit1309" is not selected for building in solution configuration "Debug|x64".
The project "unit1330" is not selected for building in solution configuration "Debug|x64".
The project "unit1395" is not selected for building in solution configuration "Debug|x64".
The project "unit1396" is not selected for building in solution configuration "Debug|x64".
The project "unit1397" is not selected for building in solution configuration "Debug|x64".
The project "unit1398" is not selected for building in solution configuration "Debug|x64".
The project "unit1600" is not selected for building in solution configuration "Debug|x64".
The project "unit1601" is not selected for building in solution configuration "Debug|x64".
The project "unit1603" is not selected for building in solution configuration "Debug|x64".
The project "unit1620" is not selected for building in solution configuration "Debug|x64".

even though TESTING is on. I'll look into that when I have more free time.

@lock lock Bot locked as resolved and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcelRaad @bagder