Repository navigation
mbedtld: release sessionid resources on error - #3574
Closed
danielgustafsson wants to merge 1 commit into
Closed
danielgustafsson wants to merge 1 commit into
danielgustafsson wants to merge 1 commit into
Conversation
If mbedtls_ssl_get_session() fails, it may still have allocated memory that needs to be freed to avoid leaking. Call the library API function to release session resources on this errorpath as well as on Curl_ssl_addsessionid() errors. Closes: #xxxx Reported-by: Michał Antoniak <M.Antoniak@posnet.com>
bagder
approved these changes
Feb 15, 2019
bagder
left a comment
bagder
left a comment
Member
There was a problem hiding this comment.
These functions are ridiculously badly documented by mbedTLS, but based on existing example code and educated guesses I think this is a step forward.
Member
|
s/mbedtld/mbedtls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If mbedtls_ssl_get_session() fails, it may still have allocated memory that needs to be freed to avoid leaking. Call the library API function to release session resources on this errorpath as well as on Curl_ssl_addsessionid() errors.
Closes: #xxxx
Reported-by: Michał Antoniak M.Antoniak@posnet.com