Repository navigation
x509 parser cleanup - #3582
Closed
bagder wants to merge 3 commits into
Closed
x509 parser cleanup#3582bagder wants to merge 3 commits into
bagder wants to merge 3 commits into
Conversation
- rename 'n' to buflen in functions, and use size_t for them. Don't pass in negative buffer lengths. - move most function comments to above the function starts like we use to - remove several unnecessary typecasts (especially of NULL)
bagder
force-pushed
the
bagder/x509-cleanup
branch
from
February 18, 2019 22:05
8cf99ff to
d9ee323
Compare
monnerat
reviewed
Feb 19, 2019
monnerat
reviewed
Feb 19, 2019
monnerat
left a comment
monnerat
left a comment
Contributor
There was a problem hiding this comment.
Except the remark at line 439 that requests a fix, I don't see any other potential problems.
Casted NULLs were coded in old days when the OS400 compiler didn't like implicit type conversion of NULL in some cases. I hope they fixed it nowadays.
Scan-build seems happy with it: now let's see what Coverity says !
Member
Author
|
The travis coverage job fails but I can't understand why, nor do I think it is related to this change. |
Contributor
Agreed, since I have the same problem on #3583. I don't understand the failure reason either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.