Skip to content

/curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x509 parser cleanup #3582

Closed
wants to merge 3 commits into from

Conversation

Reviewers

@monnerat monnerat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bagder @monnerat
@bagder
Copy link
Member

commented Feb 18, 2019

No description provided.

bagder added some commits Feb 18, 2019

@bagder
unit1651: survive curl_easy_init() fails
Verified
This commit was signed with a verified signature.
@bagder bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
2c24c78
@bagder
x509asn1: cleanup and unify code layout 
- rename 'n' to buflen in functions, and use size_t for them. Don't pass
  in negative buffer lengths.

- move most function comments to above the function starts like we use
  to

- remove several unnecessary typecasts (especially of NULL)
Verified
This commit was signed with a verified signature.
@bagder bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
d9ee323

@bagder bagder force-pushed the bagder/x509-cleanup branch from 8cf99ff to d9ee323 Feb 18, 2019

@bagder bagder requested a review from monnerat Feb 18, 2019

@monnerat

monnerat reviewed Feb 19, 2019
View changes

Show resolved Hide resolved lib/x509asn1.c
@monnerat

monnerat reviewed Feb 19, 2019
View changes

Copy link
Collaborator

left a comment

Except the remark at line 439 that requests a fix, I don't see any other potential problems.
Casted NULLs were coded in old days when the OS400 compiler didn't like implicit type conversion of NULL in some cases. I hope they fixed it nowadays.
Scan-build seems happy with it: now let's see what Coverity says !
@bagder
fixup x509asn1: make encodeOID() return 0 on error
Verified
This commit was signed with a verified signature.
@bagder bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
7a6766c
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 19, 2019

The travis coverage job fails but I can't understand why, nor do I think it is related to this change.
@monnerat

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Feb 19, 2019

The travis coverage job fails but I can't understand why, nor do I think it is related to this change.

Agreed, since I have the same problem on #3583. I don't understand the failure reason either.

@bagder bagder closed this in d8b0318 Feb 19, 2019

@bagder bagder deleted the bagder/x509-cleanup branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.