Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singlesocket: fix the 'sincebefore' placement #3589

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@bagder
Copy link
Member

commented Feb 19, 2019

The variable wasn't properly reset within the loop and thus could remain
set for sockets that hadn't been set before and thus missed notifying
the app.

Detected-by: Jan Alexander Steffens (@heftig)
Fixes #3585

singlesocket: fix the 'sincebefore' placement
The variable wasn't properly reset within the loop and thus could remain
set for sockets that hadn't been set before and thus missed notifying
the app.

Detected-by: Jan Alexander Steffens
Fixes #3585
@bagder

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2019

This is a follow-up to 4c35574, shipped in curl 7.64.0.

@jay

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

Either way I couldn't reproduce however this fix looks correct regardless

@bagder bagder closed this in afc00e0 Feb 20, 2019

@bagder bagder deleted the bagder/singlesocket-sincebefore branch Feb 20, 2019

@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.