Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor: update to Visual Studio 2017 #3606

Closed
wants to merge 3 commits into from

Conversation

@MarcelRaad
Copy link
Member

commented Feb 24, 2019

The last major update to Visual Studio 2017 has been released and is available on AppVeyor. It requires the non-default Visual Studio 2017 worker Image, which can also be used for Visual Studio 2015 and comes with more modern, but less software.

@jay

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

maybe we should get rid of 2012, does anyone use that. we'd still have a lot 2008/2010/2013/2015/2017

@bagder

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Right, holding down the amount is a good idea and presumably that single one alone rarely finds an issue for us...

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

Just curious, why 2012 out of all versions?
Maybe we can also drop 2013 and 2015 then. Language-wise and library-wise there's not much they add to having 2010 and 2017.

@dfandrich

This comment has been minimized.

Copy link
Collaborator

commented Feb 25, 2019

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

That would be Visual Studio 2008 for Windows 2000 and Visual Studio 2017 for Windows XP and Vista. It's not possible to run the tests with Visual Studio 2008, though, so we should also keep Visual Studio 2010.

@bagder

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

From my perspective it wasn't about 2012 specifically but rather thinking through if we can reduce the number of builds without sacrificing too much functionality.

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Feb 25, 2019
AppVeyor: remove redundant builds
Remove the Visual Studio 2012 and 2013 builds as they add little value.

Ref: curl#3606
Closes
@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

I've created #3614 to remove the 2012 and 2013 builds. If that's OK to merge, I'll rebase this one and add a commit to remove the 2015 build too.

@jay

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Just curious, why 2012 out of all versions?

Anecdotal. I just haven't seen it that much. I would also like to reduce the number of builds. I did some empirical searching "Visual Studio xxxx" in:file filename:.sln

Visual Studio 2005 - 182,259
Visual Studio 2008 - 340,594
Visual Studio 2010 - 468,235
Visual Studio 2012 - 342,108
Visual Studio 2013 - 549,323
Visual Studio 14 - 745,036 (14 == VS2015)
Visual Studio 15 - 587,880 (15 == VS2017)

How about 2008, 2010, 2017, and we will eventually need to add support for 2019 due out this year.

@jay

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

ah just saw your comment we posted at the same time. sounds good.

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Feb 26, 2019
AppVeyor: remove redundant builds
Remove the Visual Studio 2012 and 2013 builds as they add little value.

Ref: curl#3606
Closes curl#3614
MarcelRaad added 3 commits Feb 23, 2019
AppVeyor: explicitly select worker image
Currently, we're using the default Visual Studio 2015 image for
everything.

Closes #3606
AppVeyor: switch VS 2015 builds to VS 2017 image
The Visual Studio 2017 image has Visual Studio 2015 and 2017 installed.

Closes #3606
AppVeyor: update to Visual Studio 2017
Switch all Visual Studio 2015 builds to Visual Studio 2017. It's not a
moving target anymore as the last update, Update 9, has been released.

Closes #3606

@MarcelRaad MarcelRaad force-pushed the MarcelRaad:appveyor_vs2017 branch from 994ddbc to 7050509 Feb 26, 2019

@MarcelRaad MarcelRaad changed the title AppVeyor: add Visual Studio 2017 AppVeyor: update to Visual Studio 2017 Feb 26, 2019

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

Merged the other two changes and rebased this one.

@bagder
bagder approved these changes Feb 26, 2019
MarcelRaad added a commit that referenced this pull request Feb 26, 2019
AppVeyor: switch VS 2015 builds to VS 2017 image
The Visual Studio 2017 image has Visual Studio 2015 and 2017 installed.

Closes #3606
MarcelRaad added a commit that referenced this pull request Feb 26, 2019
AppVeyor: update to Visual Studio 2017
Switch all Visual Studio 2015 builds to Visual Studio 2017. It's not a
moving target anymore as the last update, Update 9, has been released.

Closes #3606

@MarcelRaad MarcelRaad deleted the MarcelRaad:appveyor_vs2017 branch Feb 26, 2019

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Feb 26, 2019
AppVeyor: explicitly select worker image
Currently, we're using the default Visual Studio 2015 image for
everything.

Closes curl#3606
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Feb 26, 2019
AppVeyor: switch VS 2015 builds to VS 2017 image
The Visual Studio 2017 image has Visual Studio 2015 and 2017 installed.

Closes curl#3606
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Feb 26, 2019
AppVeyor: update to Visual Studio 2017
Switch all Visual Studio 2015 builds to Visual Studio 2017. It's not a
moving target anymore as the last update, Update 9, has been released.

Closes curl#3606

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.