Repository navigation
Conversation
bagder
force-pushed
the
bagder/curl-sorted-features
branch
from
February 25, 2019 12:40
ee46bd5 to
9f1fd7b
Compare
| #elif defined(HAVE_STRCMPI) | ||
| return strcmpi(* (char * const *) p1, * (char * const *) p2); | ||
| #else | ||
| return strcmp(* (char * const *) p1, * (char * const *) p2); |
Contributor
There was a problem hiding this comment.
Does it make sense to always use the least common denominator in order to make the output consistent across plattforms?
Member
Author
There was a problem hiding this comment.
Maybe. I'm not sure how common the case is without a case sensitive function here.
I think sorting it case sensitively makes it look funny since the lowercase features end up last.
I first wanted to use curl_strequal for this, but it doesn't offer the correct return code so we can't use that. (and I didn't feel like refactor everything to make such a version available)
An alternative could be to always specify features with an uppercase first letter to sort of shortcut this, but then I think "Libz" looks odd...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.