Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: display --version features sorted alphabetically #3611

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@bagder
Copy link
Member

commented Feb 25, 2019

No description provided.

@bagder bagder added the cmdline tool label Feb 25, 2019

@bagder bagder force-pushed the bagder/curl-sorted-features branch from ee46bd5 to 9f1fd7b Feb 25, 2019

#elif defined(HAVE_STRCMPI)
return strcmpi(* (char * const *) p1, * (char * const *) p2);
#else
return strcmp(* (char * const *) p1, * (char * const *) p2);

This comment has been minimized.

Copy link
@danielgustafsson

danielgustafsson Feb 25, 2019

Member

Does it make sense to always use the least common denominator in order to make the output consistent across plattforms?

This comment has been minimized.

Copy link
@bagder

bagder Feb 25, 2019

Author Member

Maybe. I'm not sure how common the case is without a case sensitive function here.

I think sorting it case sensitively makes it look funny since the lowercase features end up last.

I first wanted to use curl_strequal for this, but it doesn't offer the correct return code so we can't use that. (and I didn't feel like refactor everything to make such a version available)

An alternative could be to always specify features with an uppercase first letter to sort of shortcut this, but then I think "Libz" looks odd...

@bagder bagder closed this in 6cc6a44 Feb 27, 2019

@bagder bagder deleted the bagder/curl-sorted-features branch Feb 27, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.