Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upcurl: display --version features sorted alphabetically #3611
Conversation
bagder
added
the
cmdline tool
label
Feb 25, 2019
bagder
force-pushed the
bagder/curl-sorted-features
branch
from
ee46bd5
to
9f1fd7b
Feb 25, 2019
danielgustafsson
reviewed
Feb 25, 2019
| #elif defined(HAVE_STRCMPI) | ||
| return strcmpi(* (char * const *) p1, * (char * const *) p2); | ||
| #else | ||
| return strcmp(* (char * const *) p1, * (char * const *) p2); |
This comment has been minimized.
This comment has been minimized.
danielgustafsson
Feb 25, 2019
Member
Does it make sense to always use the least common denominator in order to make the output consistent across plattforms?
This comment has been minimized.
This comment has been minimized.
bagder
Feb 25, 2019
Author
Member
Maybe. I'm not sure how common the case is without a case sensitive function here.
I think sorting it case sensitively makes it look funny since the lowercase features end up last.
I first wanted to use curl_strequal for this, but it doesn't offer the correct return code so we can't use that. (and I didn't feel like refactor everything to make such a version available)
An alternative could be to always specify features with an uppercase first letter to sort of shortcut this, but then I think "Libz" looks odd...
bagder commentedFeb 25, 2019
No description provided.