Skip to content

strerror: make the strerror function use local buffers - #3612

Closed
bagder wants to merge 4 commits into
masterfrom
bagder/strerror-buffer
Closed

strerror: make the strerror function use local buffers#3612
bagder wants to merge 4 commits into
masterfrom
bagder/strerror-buffer

Conversation

@bagder

@bagder bagder commented Feb 25, 2019

Copy link
Copy Markdown
Member

Instead of using a fixed 256 byte buffer in the connectdata struct.

In my build, this reduces the size of the connectdata struct by 11.8%,
from 2160 to 1904 bytes with no functionality or performance loss.

bagder and others added 4 commits February 25, 2019 18:16
@bagder
strerror: make the strerror function use local buffers
832609f 
Instead of using a fixed 256 byte buffer in the connectdata struct.

In my build, this reduces the size of the connectdata struct by 11.8%,
from 2160 to 1904 bytes with no functionality or performance loss.
@bagder
fixup some missed ones
d933dc1
@bagder
fixup more
014f2ff
@jay
fix more
927e8cc 
squashme into #3612

this also fixes a bug in schannel's Curl_verify_certificate where it
called Curl_sspi_strerror when it should have called Curl_strerror for
string from GetLastError. the only affect would have been no text or the
wrong text being shown for the error.
@jay

jay commented Feb 25, 2019

Copy link
Copy Markdown
Member

s/affect/effect in my squash

@bagder bagder closed this in 880cd5d Feb 26, 2019
@bagder
bagder deleted the bagder/strerror-buffer branch February 26, 2019 09:22
@bagder

bagder commented Feb 26, 2019

Copy link
Copy Markdown
Member Author

Thanks for the great assistance @jay!

@lock lock Bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bagder @jay