strerror: make the strerror function use local buffers #3612

bagder · 2019-02-25T17:18:12Z

Instead of using a fixed 256 byte buffer in the connectdata struct.

In my build, this reduces the size of the connectdata struct by 11.8%,
from 2160 to 1904 bytes with no functionality or performance loss.

Instead of using a fixed 256 byte buffer in the connectdata struct. In my build, this reduces the size of the connectdata struct by 11.8%, from 2160 to 1904 bytes with no functionality or performance loss.

squashme into #3612 this also fixes a bug in schannel's Curl_verify_certificate where it called Curl_sspi_strerror when it should have called Curl_strerror for string from GetLastError. the only affect would have been no text or the wrong text being shown for the error.

jay · 2019-02-25T21:29:45Z

s/affect/effect in my squash

bagder · 2019-02-26T09:22:25Z

Thanks for the great assistance @jay!

bagder and others added 4 commits February 25, 2019 18:16

strerror: make the strerror function use local buffers

832609f

Instead of using a fixed 256 byte buffer in the connectdata struct. In my build, this reduces the size of the connectdata struct by 11.8%, from 2160 to 1904 bytes with no functionality or performance loss.

fixup some missed ones

d933dc1

fixup more

014f2ff

fix more

927e8cc

squashme into #3612 this also fixes a bug in schannel's Curl_verify_certificate where it called Curl_sspi_strerror when it should have called Curl_strerror for string from GetLastError. the only affect would have been no text or the wrong text being shown for the error.

bagder closed this in 880cd5d Feb 26, 2019

bagder deleted the bagder/strerror-buffer branch February 26, 2019 09:22

lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019

strerror: make the strerror function use local buffers #3612

strerror: make the strerror function use local buffers #3612

bagder commented Feb 25, 2019

jay commented Feb 25, 2019

bagder commented Feb 26, 2019

strerror: make the strerror function use local buffers #3612

strerror: make the strerror function use local buffers #3612

Conversation

bagder commented Feb 25, 2019

jay commented Feb 25, 2019

bagder commented Feb 26, 2019