Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a segfault if flushing cookies with no CookieInfo set #3613

wants to merge 1 commit into from


Copy link

@m6w6 m6w6 commented Feb 25, 2019

a52e46f removed a NULL check, reintroduced here.

Copy link

@bagder bagder commented Feb 25, 2019

I've struggled to understand how we end up with data->cookies being NULL while data->set.str[STRING_COOKIEJAR] is set. It seeems to indicate a problem somewhere and this just paints over that symptom.

I think the explanation is related to cookie sharing and changing that share in a specific handle. Like here:


Line 1995 in 90236ed

data->cookies = NULL;

bagder approved these changes Feb 26, 2019
@bagder bagder closed this in 8eddb8f Feb 26, 2019
Copy link

@bagder bagder commented Feb 26, 2019


Copy link
Contributor Author

@m6w6 m6w6 commented Feb 26, 2019

I'm sorry, that I cannot give more insight. What I can say, though, is that I always use multi and I always use share and I always enable cookie sharing and I always flush cookies, but I do not always use a cookie file/jar.

@m6w6 m6w6 deleted the m6w6:fix-segfault-flush-cookies branch Feb 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants