Skip to content

Secure Transport: no more "darwinssl" - #3619

Closed
bagder wants to merge 1 commit into
masterfrom
bagder/secure-transport
Closed

Secure Transport: no more "darwinssl"#3619
bagder wants to merge 1 commit into
masterfrom
bagder/secure-transport

Conversation

@bagder

@bagder bagder commented Feb 26, 2019

Copy link
Copy Markdown
Member

Everyone calls it Secure Transport, now we do too.

(After previous discusssions with @nickzman and @danielgustafsson.)

@bagder bagder added the TLS label Feb 26, 2019
@bagder

bagder commented Feb 26, 2019

Copy link
Copy Markdown
Member Author

The red builds look unrelated. I'll just let it sit here for a while longer before merge in case someone wants to object or comment.

nickzman
nickzman requested changes Feb 27, 2019
View reviewed changes

@nickzman nickzman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I have some changes.

Comment thread configure.ac Outdated
Comment thread lib/vtls/sectransp.c Outdated
Comment thread configure.ac Outdated
Comment thread configure.ac Outdated
@bagder
Secure Transport: no more "darwinssl"
43e1c72 
Everyone calls it Secure Transport, now we do too.

Reviewed-by: Nick Zitzmann

Closes #3619
@bagder
bagder force-pushed the bagder/secure-transport branch from 2b08ab0 to 43e1c72 Compare February 27, 2019 06:43
@bagder
bagder requested a review from nickzman February 27, 2019 06:43
@bagder

bagder commented Feb 27, 2019

Copy link
Copy Markdown
Member Author

Thanks @nickzman, I believe I addressed the nits you identified.

nickzman
nickzman requested changes Feb 28, 2019
View reviewed changes

@nickzman nickzman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost! The code itself builds and runs fine. There's a discrepancy between what the configure script advertises it takes and what it actually takes.

Comment thread configure.ac
Comment thread configure.ac
@bagder bagder closed this in 76a9c3c Feb 28, 2019
@bagder
bagder deleted the bagder/secure-transport branch February 28, 2019 07:48
@webmaster128

webmaster128 commented Mar 29, 2019

Copy link
Copy Markdown
Contributor

Is it possible that this change broke the root cmake file? In https://github.com/curl/curl/blob/curl-7_64_1/CMakeLists.txt#L344 the old name is still used.

I am experiencing a new crash in my application because curl_version_info_data.ssl_version is nullptr since I upgraded from 7.63.0 to 7.64.1. I set CMAKE_USE_DARWINSSL to ON, which worked so far.

@bagder

bagder commented Mar 29, 2019

Copy link
Copy Markdown
Member Author

Ah, I bet we have no CI tests for that build combo! 👎 Can you file this as a new issue (or PR if you have the time)?

@webmaster128 webmaster128 mentioned this pull request Apr 5, 2019
Closed
@webmaster128 webmaster128 mentioned this pull request Apr 12, 2019
Closed
@lock lock Bot locked as resolved and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nickzman nickzman nickzman requested changes

Assignees

No one assigned

Labels

TLS

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bagder @webmaster128 @nickzman