New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secure Transport: no more "darwinssl" #3619
Conversation
The red builds look unrelated. I'll just let it sit here for a while longer before merge in case someone wants to object or comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I have some changes.
Everyone calls it Secure Transport, now we do too. Reviewed-by: Nick Zitzmann Closes #3619
2b08ab0
to
43e1c72
Compare
Thanks @nickzman, I believe I addressed the nits you identified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost! The code itself builds and runs fine. There's a discrepancy between what the configure script advertises it takes and what it actually takes.
Is it possible that this change broke the root cmake file? In https://github.com/curl/curl/blob/curl-7_64_1/CMakeLists.txt#L344 the old name is still used. I am experiencing a new crash in my application because |
Ah, I bet we have no CI tests for that build combo! |
Everyone calls it Secure Transport, now we do too.
(After previous discusssions with @nickzman and @danielgustafsson.)