Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure Transport: no more "darwinssl" #3619

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

commented Feb 26, 2019

Everyone calls it Secure Transport, now we do too.

(After previous discusssions with @nickzman and @danielgustafsson.)

@bagder bagder added the SSL/TLS label Feb 26, 2019

@bagder

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

The red builds look unrelated. I'll just let it sit here for a while longer before merge in case someone wants to object or comment.

@nickzman
Copy link
Collaborator

left a comment

Thanks for working on this. I have some changes.

configure.ac Outdated Show resolved Hide resolved
lib/vtls/sectransp.c Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
Secure Transport: no more "darwinssl"
Everyone calls it Secure Transport, now we do too.

Reviewed-by: Nick Zitzmann

Closes #3619

@bagder bagder force-pushed the bagder/secure-transport branch from 2b08ab0 to 43e1c72 Feb 27, 2019

@bagder bagder requested a review from nickzman Feb 27, 2019

@bagder

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2019

Thanks @nickzman, I believe I addressed the nits you identified.

@nickzman
Copy link
Collaborator

left a comment

Almost! The code itself builds and runs fine. There's a discrepancy between what the configure script advertises it takes and what it actually takes.

configure.ac Show resolved Hide resolved
configure.ac Show resolved Hide resolved

@bagder bagder closed this in 76a9c3c Feb 28, 2019

@bagder bagder deleted the bagder/secure-transport branch Feb 28, 2019

@webmaster128

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

Is it possible that this change broke the root cmake file? In https://github.com/curl/curl/blob/curl-7_64_1/CMakeLists.txt#L344 the old name is still used.

I am experiencing a new crash in my application because curl_version_info_data.ssl_version is nullptr since I upgraded from 7.63.0 to 7.64.1. I set CMAKE_USE_DARWINSSL to ON, which worked so far.

@bagder

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

Ah, I bet we have no CI tests for that build combo! 👎 Can you file this as a new issue (or PR if you have the time)?

@lock lock bot locked as resolved and limited conversation to collaborators Jun 27, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.