Secure Transport: no more "darwinssl" #3619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The red builds look unrelated. I'll just let it sit here for a while longer before merge in case someone wants to object or comment. |
nickzman
requested changes
Feb 27, 2019
Everyone calls it Secure Transport, now we do too. Reviewed-by: Nick Zitzmann Closes #3619
bagder
force-pushed
the
bagder/secure-transport
branch
from
2b08ab0
to
43e1c72
Compare
|
Thanks @nickzman, I believe I addressed the nits you identified. |
nickzman
requested changes
Feb 28, 2019
|
Is it possible that this change broke the root cmake file? In https://github.com/curl/curl/blob/curl-7_64_1/CMakeLists.txt#L344 the old name is still used. I am experiencing a new crash in my application because |
|
Ah, I bet we have no CI tests for that build combo! 👎 Can you file this as a new issue (or PR if you have the time)? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everyone calls it Secure Transport, now we do too.
(After previous discusssions with @nickzman and @danielgustafsson.)