Repository navigation
Conversation
.. since system_win32 is a more appropriate location for the functions and to extern the globals. Ref: curl@ca597ad#r32446578 Reported-by: Gisle Vanem Closes #xxxx
Member
|
The codacy red can be ignored. |
Member
|
I don't completely understand the Codacy failure - will it ever go away if this is merged as-is or will it stay red forever then? The MinGW failures look legitimate, though: |
Member
I think Codacy only makes red builds when it finds new issues. If you go there, you can see that it currently lists hundreds of existing issues. Most of them being benign and debatable, but some probably worthy to address. |
MarcelRaad
approved these changes
Mar 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. since system_win32 is a more appropriate location for the functions
and to extern the globals.
Ref: ca597ad#r32446578
Reported-by: Gisle Vanem
Closes #xxxx
/cc @gvanem