Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_win32: move win32_init here from easy.c #3625

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@jay
Copy link
Member

commented Feb 28, 2019

.. since system_win32 is a more appropriate location for the functions
and to extern the globals.

Ref: ca597ad#r32446578
Reported-by: Gisle Vanem

Closes #xxxx


/cc @gvanem

system_win32: move win32_init here from easy.c
.. since system_win32 is a more appropriate location for the functions
and to extern the globals.

Ref: ca597ad#r32446578
Reported-by: Gisle Vanem

Closes #xxxx

@jay jay added the Windows label Feb 28, 2019

@bagder

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

The codacy red can be ignored.

@MarcelRaad

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

I don't completely understand the Codacy failure - will it ever go away if this is merged as-is or will it stay red forever then?

The MinGW failures look legitimate, though:

system_win32.c: In function 'Curl_win32_init':
system_win32.c:85:23: error: implicit declaration of function 'Curl_sspi_global_init' [-Werror=implicit-function-declaration]
     CURLcode result = Curl_sspi_global_init();
                       ^~~~~~~~~~~~~~~~~~~~~
system_win32.c: In function 'Curl_win32_cleanup':
system_win32.c:106:3: error: implicit declaration of function 'Curl_sspi_global_cleanup' [-Werror=implicit-function-declaration]
   Curl_sspi_global_cleanup();
   ^~~~~~~~~~~~~~~~~~~~~~~~
@bagder

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

will it ever go away if this is merged as-is or will it stay red forever then?

I think Codacy only makes red builds when it finds new issues. If you go there, you can see that it currently lists hundreds of existing issues. Most of them being benign and debatable, but some probably worthy to address.

@jay jay closed this in db374c5 Mar 2, 2019

@jay jay deleted the jay:move_win32_init branch Mar 2, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.