socket handling and WIN32 WSACleanup fixes #3663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2019 23:15
…s a missing call to WSACleanup() in the WIN32 case, per Microsoft's Winsock2 documentation: https://docs.microsoft.com/en-us/windows/desktop/api/winsock/nf-winsock-wsacleanup WSACleanup() should ideally be called before any return from main() that occurs after the call to WSAStartup().
https://docs.microsoft.com/en-us/windows/desktop/api/winsock/nf-winsock-wsacleanup WSACleanup() should ideally be called before any return from main() that occurs after the call to WSAStartup().
jay
requested changes
Mar 11, 2019
|
Try |
Corrected. Thanks! |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of nitpicks in docs/examples/externalsocket.c:
In the event that servaddr.sin_addr.s_addr is INADDR_NONE, the example code leaks sockfd. This would matter if someone copied the code into a function that wasn't main()... ;-)
Microsoft's Winsock documentation states that a matching call to WSACleanup() should be called for every WSAStartup() call performed.