Skip to content

conncache: use conn->data to know if a transfer owns it - #3686

Closed
bagder wants to merge 3 commits into
masterfrom
bagder/connnection-in-use
Closed

conncache: use conn->data to know if a transfer owns it#3686
bagder wants to merge 3 commits into
masterfrom
bagder/connnection-in-use

Conversation

@bagder

@bagder bagder commented Mar 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

  • make sure an already "owned" connection isn't returned unless
    multiplexed.

  • clear ->data when returning the connection to the cache again

Regression since at some time before 7.62.0 (probably 1b76c38)

Bug: https://curl.haxx.se/mail/lib-2019-03/0064.html

bagder added 3 commits March 17, 2019 00:49
@bagder
conncache: use conn->data to know if a transfer owns it
3e21823 
- make sure an already "owned" connection isn't returned unless
  multiplexed.

- clear ->data when returning the connection to the cache again

Regression since at some time before 7.62.0

Bug: https://curl.haxx.se/mail/lib-2019-03/0064.html
@bagder
fixup the ConnectionExists check for ->data == NULL case
669bbb7
@bagder
fixup another use of CONN_INUSE() that also needs to check conn->data
d972f3a
@bagder bagder closed this in e3a53e3 Mar 17, 2019
@bagder
bagder deleted the bagder/connnection-in-use branch March 17, 2019 17:09
@lock lock Bot locked as resolved and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bagder