Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Avoid unportable `==' test(1) operator in configure.ac #3709
Hello Daniel, Daniel Stenberg writes:
Oops, how silly. How did you catch this? Thinking what we should do to catch the next mistake like this...
In pkgsrc this is taken care by the infrastructure mk/check/check-portability.* makefile^ and scripts^. check-portability.sh generate a list of files and checks are done via check-portability.awk. I think that they are probably easy to adapt also outside pkgsrc and in my experience it's pretty rare that they report any false positive (at least I don't recall any in the more than a decade :)). : <https://github.com/NetBSD/pkgsrc/blob/trunk/mk/check/check-portability.mk> : <https://github.com/NetBSD/pkgsrc/blob/trunk/mk/check/check-portability.sh> : <https://github.com/NetBSD/pkgsrc/blob/trunk/mk/check/check-portability.awk>
I tried checkbashisms (from the Debian devscripts package, version 2.19.4) but when I run it against