Avoid unportable `==' test(1) operator in configure.ac

[iamleot]

When updating www/curl package in pkgsrc the pkgsrc checks spotted
the non-portable == operator (= can be used instead).

[bagder]

Oops, how silly. How did you catch this? Thinking what we should do to catch the next mistake like this...

[iamleot]

Hello Daniel, Daniel Stenberg writes:

Oops, how silly. How did you catch this? Thinking what we should do to catch the next mistake like this...

In pkgsrc this is taken care by the infrastructure mk/check/check-portability.* makefile^[0] and scripts^[1][2]. check-portability.sh generate a list of files and checks are done via check-portability.awk. I think that they are probably easy to adapt also outside pkgsrc and in my experience it's pretty rare that they report any false positive (at least I don't recall any in the more than a decade :)). [0]: <https://github.com/NetBSD/pkgsrc/blob/trunk/mk/check/check-portability.mk> [1]: <https://github.com/NetBSD/pkgsrc/blob/trunk/mk/check/check-portability.sh> [2]: <https://github.com/NetBSD/pkgsrc/blob/trunk/mk/check/check-portability.awk>

[dfandrich]

Debian also has the checkbashisms script (in the devscripts package) that does something similar.

[bagder]

I tried checkbashisms (from the Debian devscripts package, version 2.19.4) but when I run it against configure (with the bashism @iamleot reported still present) it finds nothing to report. If I run it against configure.ac instead it finds it, but it then also complains on a lot of other things that seem to be because it isn't actually a shell script...

[bagder]

Thanks!

[michael-o]

Had the same issue on HP-UX:

checking whether to enable Amiga native SSL/TLS (AmiSSL)... ./configure[22255]: ==: A test command parameter is not valid.

[bagder]

@michael-o in 7.65.0 ?

[michael-o]

@bagder No, just tried 7.65.0 and it is fine now.