Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unportable `==' test(1) operator in configure.ac #3709

Closed
wants to merge 1 commit into from

Conversation

@iamleot
Copy link
Contributor

commented Mar 27, 2019

When updating www/curl package in pkgsrc the pkgsrc checks spotted
the non-portable == operator (= can be used instead).

@bagder

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Oops, how silly. How did you catch this? Thinking what we should do to catch the next mistake like this...

@bagder bagder added the build label Mar 27, 2019
@iamleot

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

@dfandrich

This comment has been minimized.

Copy link
Collaborator

commented Mar 27, 2019

@bagder

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

I tried checkbashisms (from the Debian devscripts package, version 2.19.4) but when I run it against configure (with the bashism @iamleot reported still present) it finds nothing to report. If I run it against configure.ac instead it finds it, but it then also complains on a lot of other things that seem to be because it isn't actually a shell script...

@bagder

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Thanks!

@bagder bagder closed this in 8759e33 Mar 27, 2019
@michael-o

This comment has been minimized.

Copy link
Member

commented May 27, 2019

Had the same issue on HP-UX:

checking whether to enable Amiga native SSL/TLS (AmiSSL)... ./configure[22255]: ==: A test command parameter is not valid.
@bagder

This comment has been minimized.

Copy link
Member

commented May 27, 2019

@michael-o in 7.65.0 ?

@michael-o

This comment has been minimized.

Copy link
Member

commented May 27, 2019

@bagder No, just tried 7.65.0 and it is fine now.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.