Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use per stream_id user data. #372

Closed
wants to merge 1 commit into from

Conversation

@Andersbakken
Copy link
Contributor

commented Aug 11, 2015

Use nghttp2_session_get_stream_user_data/nghttp2_session_set_stream_user_data
to identify SessionaHandles instead of a hash.

Return 0 instead of NGHTTP2_ERR_CALLBACK_FAILURE if we can't locate the
SessionHandle. Apparently mod_h2 will sometimes send a frame for a
stream_id we're finished with.

Use per stream_id user data.
Use nghttp2_session_get_stream_user_data/nghttp2_session_set_stream_user_data
to identify SessionaHandles instead of a hash.

Return 0 instead of NGHTTP2_ERR_CALLBACK_FAILURE if we can't locate the
SessionHandle. Apparently mod_h2 will sometimes send a frame for a
stream_id we're finished with.

@Andersbakken Andersbakken force-pushed the Andersbakken:mod_h2_fix_v2 branch to 26acc5a Aug 11, 2015

@bagder bagder closed this in 5778e6f Aug 11, 2015

jgsogo added a commit to jgsogo/curl that referenced this pull request Oct 19, 2015
http2: discard frames with no SessionHandle
Return 0 instead of NGHTTP2_ERR_CALLBACK_FAILURE if we can't locate the
SessionHandle. Apparently mod_h2 will sometimes send a frame for a
stream_id we're finished with.

Use nghttp2_session_get_stream_user_data and
nghttp2_session_set_stream_user_data to identify SessionHandles instead
of a hash.

Closes curl#372

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.