Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUse per stream_id user data. #372
Conversation
Andersbakken
force-pushed the
Andersbakken:mod_h2_fix_v2
branch
to
26acc5a
Aug 11, 2015
bagder
closed this
in
5778e6f
Aug 11, 2015
bagder
referenced this pull request
Aug 11, 2015
Closed
Remove SessionHandle from streamsh hash in Curl_http_done. #373
jgsogo
added a commit
to jgsogo/curl
that referenced
this pull request
Oct 19, 2015
lock
bot
locked as resolved and limited conversation to collaborators
Jan 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Andersbakken commentedAug 11, 2015
Use nghttp2_session_get_stream_user_data/nghttp2_session_set_stream_user_data
to identify SessionaHandles instead of a hash.
Return 0 instead of NGHTTP2_ERR_CALLBACK_FAILURE if we can't locate the
SessionHandle. Apparently mod_h2 will sometimes send a frame for a
stream_id we're finished with.