New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use per stream_id user data. #372

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@Andersbakken
Contributor

Andersbakken commented Aug 11, 2015

Use nghttp2_session_get_stream_user_data/nghttp2_session_set_stream_user_data
to identify SessionaHandles instead of a hash.

Return 0 instead of NGHTTP2_ERR_CALLBACK_FAILURE if we can't locate the
SessionHandle. Apparently mod_h2 will sometimes send a frame for a
stream_id we're finished with.

Use per stream_id user data.
Use nghttp2_session_get_stream_user_data/nghttp2_session_set_stream_user_data
to identify SessionaHandles instead of a hash.

Return 0 instead of NGHTTP2_ERR_CALLBACK_FAILURE if we can't locate the
SessionHandle. Apparently mod_h2 will sometimes send a frame for a
stream_id we're finished with.

@bagder bagder closed this in 5778e6f Aug 11, 2015

jgsogo added a commit to jgsogo/curl that referenced this pull request Oct 19, 2015

http2: discard frames with no SessionHandle
Return 0 instead of NGHTTP2_ERR_CALLBACK_FAILURE if we can't locate the
SessionHandle. Apparently mod_h2 will sometimes send a frame for a
stream_id we're finished with.

Use nghttp2_session_get_stream_user_data and
nghttp2_session_set_stream_user_data to identify SessionHandles instead
of a hash.

Closes curl#372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment