Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS projects: use Unicode for VC10+ #3720

Closed
wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

commented Apr 2, 2019

All Windows APIs have been natively UTF-16 since Windows 2000 and the
non-Unicode variants are just wrappers around them. Only Windows 9x
doesn't understand Unicode without the UnicoWS DLL. As later Visual
Studio versions cannot target Windows 9x anyway, using the ANSI API
doesn't really have any benefit there.

This avoids issues like KNOWN_BUGS 6.5.

Ref: #2120

Closes

All Windows APIs have been natively UTF-16 since Windows 2000 and the
non-Unicode variants are just wrappers around them. Only Windows 9x
doesn't understand Unicode without the UnicoWS DLL. As later Visual
Studio versions cannot target Windows 9x anyway, using the ANSI API
doesn't really have any benefit there.

This avoids issues like KNOWN_BUGS 6.5.

Ref: #2120

Closes
@jay

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

I suspect there are a number of places where we pass char strings to windows API calls without calling the ANSI specific version. Maybe I'm wrong though.

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

Those have been fixed with d40f4e1 almost two years ago. I've been using only the Unicode version of curl ever since then (and of libcurl since 2011).

@jay

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Ok let's try it out.

@MarcelRaad MarcelRaad closed this in 16c1e44 Apr 4, 2019
@MarcelRaad MarcelRaad deleted the MarcelRaad:vs_projects_unicode branch Apr 4, 2019
@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

OK, thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.