Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: only install required apt packages #3721

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
3 participants
@MarcelRaad
Copy link
Member

commented Apr 2, 2019

This allows to selectively update some clang jobs to xenial as the LLVM repository name is different for xenial than for trusty. Also, it saves a little time for most Linux jobs.

MarcelRaad added some commits Apr 2, 2019

travis: install clang only when needed
This reduces the GCC job runtimes a little and it's needed to
selectively update clang builds to xenial.

Closes
travis: install lcov only for the coverage job
Reduces the time needed for the other jobs a little.

Closes
travis: install krb5-user only for --with-gssapi build
Reduces the time needed for the other jobs a little.

Closes
travis: install libssh-dev only for --with-libssh build
Reduces the time needed for the other jobs a little.

Closes
travis: install libssh2-dev only for --with-libssh2 build
Reduces the time needed for the other jobs a little.

Closes
travis: install libnss3-dev only for --with-nss build
Reduces the time needed for the other jobs a little.

Closes
travis: install libgnutls28-dev only for --with-gnutls build
Reduces the time needed for the other jobs a little.

Closes

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install clang only when needed
This reduces the GCC job runtimes a little and it's needed to
selectively update clang builds to xenial.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install lcov only for the coverage job
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install krb5-user only for --with-gssapi build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install libssh-dev only for --with-libssh build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install libssh2-dev only for --with-libssh2 build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install libnss3-dev only for --with-nss build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install libgnutls28-dev only for --with-gnutls build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install clang only when needed
This reduces the GCC job runtimes a little and it's needed to
selectively update clang builds to xenial.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install lcov only for the coverage job
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install krb5-user only for --with-gssapi build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install libssh-dev only for --with-libssh build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install libssh2-dev only for --with-libssh2 build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install libnss3-dev only for --with-nss build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 3, 2019

travis: install libgnutls28-dev only for --with-gnutls build
Reduces the time needed for the other jobs a little.

Closes curl#3721
@danielgustafsson
Copy link
Member

left a comment

Is it possible to also only compile dependencies such as MesaLink for the mesalink jobs? This is currently done in before_script but my Travis skills aren't up to scratch for figuring out if that can be made job dependent.

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

I wondered about that too. Probably @bagder had a good reason to do that starting in 277d3cd for mbedtls (and then for wolfssl and mesalink) as the prior brotli and BoringSSL builds were only executed for those jobs?

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

FYI: I hope we can get rid of some of those manually built dependencies. I have another branch based on this one to update some jobs to Xenial (not all though because Xenial's Valgrind doesn't like Xenial's OpenSSL, which is why this PR is needed). Xenial contains some of the dependencies missing in Trusty (but at least wolfSSL's version is too old for test 311).

@bagder

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

@bagder had a good reason to do that starting in 277d3cd for mbedtls (and then for wolfssl and mesalink)

Who really knows how travis works? I certainly don't and mostly try every possible combination until it seems to behave... My intentions were that the builds of those dependencies should end up in directories that are cached between invokes so that only 'make install' would be necessary for most builds when the cache is used. We can of course polish the logic so that we only 'make install' dependencies that are actually used.

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 11, 2019

travis: install lcov only for the coverage job
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 11, 2019

travis: install krb5-user only for --with-gssapi build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 11, 2019

travis: install libssh-dev only for --with-libssh build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 11, 2019

travis: install libssh2-dev only for --with-libssh2 build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 11, 2019

travis: install libnss3-dev only for --with-nss build
Reduces the time needed for the other jobs a little.

Closes curl#3721

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 11, 2019

travis: install libgnutls28-dev only for --with-gnutls build
Reduces the time needed for the other jobs a little.

Closes curl#3721

@MarcelRaad MarcelRaad deleted the MarcelRaad:travis_apt_cleanup branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.