Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: fix default location for fish completions #3723

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@eli-schwartz
Copy link
Contributor

commented Apr 3, 2019

Fish defines a vendor completions directory for completions that are not installed as part of the fish project itself, and the vendor completions are preferred if they exist. This prevents trying to overwrite the builtin curl.fish completion (or creating file conflicts in distro packaging).

Prefer the pkg-config defined location exported by fish, if it can be found, and fall back to the correct directory defined by most systems.

install: fix default location for fish completions
Fish defines a vendor completions directory for completions that are not
installed as part of the fish project itself, and the vendor completions
are preferred if they exist. This prevents trying to overwrite the
builtin curl.fish completion (or creating file conflicts in distro
packaging).

Prefer the pkg-config defined location exported by fish, if it can be
found, and fall back to the correct directory defined by most systems.
@danielgustafsson
Copy link
Member

left a comment

Not knowing Fish, but reading the documentation this seems like the correct approach.

@danielgustafsson

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

This PR failed in the pipeline on Travis network errors, unless objections I plan to merge this shortly.

@eli-schwartz eli-schwartz deleted the eli-schwartz:fish-install-dir branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.