Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LGTM alerts #3732

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@MarcelRaad
Copy link
Member

commented Apr 5, 2019

Fix "Comparison is always true" in transfer.c and "Empty block without comment" in ftplistparser.c. The rest is only about FIXMEs.

MarcelRaad added some commits Apr 5, 2019

transfer: fix LGTM alert "Comparison is always true"
Just remove the redundant condition, which also makes it clear that
k->buf is always 0-terminated if this break is not hit.

Closes
ftplistparser: fix LGTM alert "Empty block without comment"
Removing the block is consistent with line 954/957.

Closes
@bagder

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

This pull request fixes 2 alerts when merging 74d8f7d into f5a7747 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same
  • 1 for Empty branch of conditional

Comment posted by LGTM.com

@bagder

bagder approved these changes Apr 5, 2019

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 5, 2019

ftplistparser: fix LGTM alert "Empty block without comment"
Removing the block is consistent with line 954/957.

Closes curl#3732

@MarcelRaad MarcelRaad closed this in 1369b74 Apr 5, 2019

@MarcelRaad MarcelRaad deleted the MarcelRaad:lgtm branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.