Fix LGTM alerts - #3732
Closed
MarcelRaad wants to merge 2 commits into
Closed
Conversation
Just remove the redundant condition, which also makes it clear that k->buf is always 0-terminated if this break is not hit. Closes
Removing the block is consistent with line 954/957. Closes
Member
|
This pull request fixes 2 alerts when merging 74d8f7d into f5a7747 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
bagder
approved these changes
Apr 5, 2019
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Apr 5, 2019
Removing the block is consistent with line 954/957. Closes curl#3732
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "Comparison is always true" in transfer.c and "Empty block without comment" in ftplistparser.c. The rest is only about FIXMEs.