Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SSL_BACKENDS from cmake build #3736

Closed
wants to merge 2 commits into from

Conversation

@webmaster128
Copy link
Contributor

commented Apr 5, 2019

This groups all SSL backends into the feature "SSL" and sets the SSL_BACKENDS analogue to configure.ac.

This is a preparation for #3733 but independent of the DarwinSSL issue.

Before

$ bash /build_dir/curl/curl-config --features
DarwinSSL
IPv6
unix-sockets
libz
AsynchDNS
$ bash /build_dir/curl/curl-config --ssl-backends

After

$ bash /build_dir/curl/curl-config --features
SSL
IPv6
unix-sockets
libz
AsynchDNS
$ bash /build_dir/curl/curl-config --ssl-backends
DarwinSSL
Copy link
Member

left a comment

Cool! This should also fix test 1014 on AppVeyor for the WinSSL and OpenSSL builds.

@MarcelRaad

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Unfortunately, the CMake build failed for the non-SSL builds on AppVeyor:

-- Enabled features: IPv6 AsynchDNS
-- Enabled protocols: DICT FILE FTP GOPHER HTTP IMAP LDAP POP3 RTSP SMTP TELNET TFTP
CMake Error at CMakeLists.txt:1249 (list):
list sub-command SORT requires list to be present.

@webmaster128

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Thanks @MarcelRaad! Hmm, looks like due to the lack of a proper type system, there is no way to create an empty list. So we need to check if the variable is empty before trying to sort, which adds 2 additional lines for each of those lists. I'll do that later today or tomorrow if nobody has a better idea that allows us to call sort on every element count >= 0.

webmaster128 added 2 commits Apr 6, 2019
In case of an empty list, SORTing leads to the cmake error "list
sub-command SORT requires list to be present."
This groups all SSL backends into the feature "SSL" and sets the
SSL_BACKENDS analogue to configure.ac
@webmaster128 webmaster128 force-pushed the webmaster128:use-dawinssl-cmake branch from 57e6aa7 to 4d352c9 Apr 6, 2019
@webmaster128

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

I could reproduce the problem locally with no SSL backend enabled and fixed it now.

@MarcelRaad

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Great, thanks! The AppVeyor failures are only the usual "slow response" tests, so I'm merging now.

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 6, 2019
This groups all SSL backends into the feature "SSL" and sets the
SSL_BACKENDS analogue to configure.ac

Closes curl#3736
@MarcelRaad MarcelRaad closed this in 1a3aa5c Apr 6, 2019
@webmaster128 webmaster128 deleted the webmaster128:use-dawinssl-cmake branch Apr 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.