Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codacy warnings #3739

Closed
wants to merge 5 commits into from

Conversation

@MarcelRaad
Copy link
Member

commented Apr 5, 2019

Mostly from CppCheck. Some fixes for unused local variable warnings would have been nicer with C99, being able to declare them in the right preprocessor condition block.

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

Is there any area keyword I can use in the commit titles when touching everything, including even the packages directory? I haven't found one consistently used.

@jay

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

I haven't found one consistently used.

my opinion - use build: and squash

build: fix codacy warnings

- Consistently use WIN32 macros in Windows.

- Fix unused local variable warnings.

Some variables are only used conditionally, so also declare them conditionally.

- Fix no-consecutive-blank-lines Codacy warning.

- Suppress unused variable warnings.

- etc

Closes #xxxx
lib/if2ip.c Outdated Show resolved Hide resolved
@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2019

my opinion - use build: and squash

Thanks @jay , makes sense!

MarcelRaad added 5 commits Apr 5, 2019
Consistently use one blank line between blocks.

Closes #3739
Closes #3739
These variables are only conditionally initialized.

Closes #3739
Make functions no-ops if neither both USE_THREADS_POSIX and
HAVE_PTHREAD_H nor both USE_THREADS_WIN32 and HAVE_PROCESS_H are
defined. Previously, if only one of them was defined, there was either
code compiled that did nothing useful or the wrong header included for
the functions used.

Also, move POLARSSL_MUTEX_T define to implementation file as it's not
used externally.

Closes #3739
- remove unused variables
- declare conditionally used variables conditionally
- suppress unused variable warnings in the CMake tests
- remove dead variable stores
- consistently use WIN32 macro to detect Windows

Closes #3739
@MarcelRaad MarcelRaad force-pushed the MarcelRaad:codacy_fixes branch from 305bbec to 49d982d Apr 6, 2019
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 11, 2019
Closes curl#3739
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 11, 2019
These variables are only conditionally initialized.

Closes curl#3739
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 11, 2019
Make functions no-ops if neither both USE_THREADS_POSIX and
HAVE_PTHREAD_H nor both USE_THREADS_WIN32 and HAVE_PROCESS_H are
defined. Previously, if only one of them was defined, there was either
code compiled that did nothing useful or the wrong header included for
the functions used.

Also, move POLARSSL_MUTEX_T define to implementation file as it's not
used externally.

Closes curl#3739
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 11, 2019
- remove unused variables
- declare conditionally used variables conditionally
- suppress unused variable warnings in the CMake tests
- remove dead variable stores
- consistently use WIN32 macro to detect Windows

Closes curl#3739
@MarcelRaad MarcelRaad deleted the MarcelRaad:codacy_fixes branch Apr 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.