Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/server/util: fix Windows Unicode build #3758

Closed
wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

commented Apr 10, 2019

Always use the ANSI version of FormatMessage as we don't have the
curl_multibyte gear available here.

Always use the ANSI version of FormatMessage as we don't have the
curl_multibyte gear available here.

Closes
@captain-caveman2k

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

It seems like a straight forward fix. It has my thumbs up.

It might be worth considering the use of curl_multibyte in future though. Looking at Makefile.inc we could potentially add it to CURLX_SRCS and CURLX_INCS.

@MarcelRaad MarcelRaad deleted the MarcelRaad:tests_windows_unicode branch Apr 11, 2019
@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

Thanks! I'll look into that.

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 14, 2019
This will also be needed in the tool and tests.

Ref: curl#3758 (comment)
Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Apr 14, 2019
Now that we have the multibyte gear available in the tests, we can use
the proper Unicode version of the function.

Ref: curl#3758 (comment)
Closes
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.