Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
cmake: migrate from USE_DARWINSSL to USE_SECTRANSP #3769
One thing I find quite ugly is the usage of CMAKE_ prefix for our options/variables.
What I like about the current setup is having two distinct variables for two different levels. As you can see in a commit-by-commit review, the first commit alone would have closed #3733 by changing the internal USE_DARWINSSL -> USE_SECTRANSP without changing the public cmake interface.
I have no opinion on the nicest possible naming for cmake options, as I am not a cmake expert.