Skip to content

CURLOPT_MAXAGE_CONN: the maximum allowed age for connection reuse - #3782

Closed
bagder wants to merge 2 commits into
masterfrom
bagder/maxage-reuse-conn
Closed

CURLOPT_MAXAGE_CONN: the maximum allowed age for connection reuse#3782
bagder wants to merge 2 commits into
masterfrom
bagder/maxage-reuse-conn

Conversation

@bagder

@bagder bagder commented Apr 15, 2019

Copy link
Copy Markdown
Member

... and disconnection too old ones. The limit is right now set hardcoded
to 120 seconds. We can consider offering a configurable value in the
future.

@jay

jay commented Apr 16, 2019

Copy link
Copy Markdown
Member

I suggest a ref to #3722 in your commit message since some discussion took place there.

@bagder

bagder commented Apr 17, 2019

Copy link
Copy Markdown
Member Author

I elaborated on this change a bit on the mailing list and opened for feedback.

@bagder
bagder force-pushed the bagder/maxage-reuse-conn branch from e206287 to 6750797 Compare April 18, 2019 07:02
@bagder bagder changed the title ConnectionExists: only reuse relatively fresh connections CURLOPT_MAXAGE_CONN: the maximum allowed age for connection reuse Apr 18, 2019
captain-caveman2k referenced this pull request Apr 18, 2019
@bagder
ConnectionExists: only reuse relatively fresh connections
e24dca2 
... and disconnect too old ones. The limit is right now set hardcoded to
120 seconds. We can consider offering a configurable value in the
future.

Ref: #3722
Closes #3780
@bagder

bagder commented Apr 19, 2019

Copy link
Copy Markdown
Member Author

oops! 😄

@bagder
CURLOPT_MAXAGE_CONN: set the maximum allowed age for conn reuse
d5a39d3 
... and disconnect too old ones instead of trying to reuse.

Ref: #3722
Closes #3782
@bagder
bagder force-pushed the bagder/maxage-reuse-conn branch from 4da30d1 to d5a39d3 Compare April 19, 2019 15:04
@pps83

pps83 commented Apr 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

I elaborated on this change a bit on the mailing list and opened for feedback.

I think forcing it to 120s isn't ok for those who intentionally rely on TCP_KEEPALIVE and long living connections. IMO it should be configurable and set to some kind of reasonable value by default (120s seems ok).

@bagder

bagder commented Apr 20, 2019

Copy link
Copy Markdown
Member Author

As you can see in this patch set, it is now configurable and is at 118 seconds by default.

@bagder

bagder commented Apr 20, 2019

Copy link
Copy Markdown
Member Author

TCP KEEPALIVE is rarely helping beyond the first few minutes since the time here is usually limited by how long the remote server keeps the connection alive. That's commonly limited to a few minutes at the most.

@bagder bagder closed this in e649432 Apr 21, 2019
@bagder
bagder deleted the bagder/maxage-reuse-conn branch April 21, 2019 21:07
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

connecting & proxies

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bagder @jay @pps83