Skip to content

urlapi: add CURLUPART_ZONEID to set and get - #3834

Closed
bagder wants to merge 2 commits into
masterfrom
bagder/urlapi-zoneid
Closed

urlapi: add CURLUPART_ZONEID to set and get#3834
bagder wants to merge 2 commits into
masterfrom
bagder/urlapi-zoneid

Conversation

@bagder

@bagder bagder commented May 3, 2019

Copy link
Copy Markdown
Member

The zoneid can be used with IPv6 numerical addresses.

Updated test 1560 to verify.

bagder added 2 commits May 3, 2019 13:18
The zoneid can be used with IPv6 numerical addresses.

Updated test 1560 to verify.
@bagder bagder closed this in 2d0e9b4 May 5, 2019
@bagder
bagder deleted the bagder/urlapi-zoneid branch May 5, 2019 13:53
@jay

jay commented May 5, 2019

Copy link
Copy Markdown
Member

I think this should have waited until next feature window, I assumed that's why you did it separately.

@bagder

bagder commented May 5, 2019

Copy link
Copy Markdown
Member Author

That was my original intention too. I went back and forth on it and the fact that we can't extract the zone id from the URL is an actual bug and I finally landed it since I figured the risk is still minimal and with this landed, we can actually also fix the zoneid bugs we have internally using the proper parsing API...

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants