Allow disabling of more features - #3844
Closed
bagder wants to merge 5 commits into
Closed
Conversation
Member
Author
|
Blah, silly me. It broke because it relies on something like #3846 so I'll get that fixed and landed first, then fixup this branch again and push a fix. |
bagder
force-pushed
the
bagder/disable-more-features
branch
from
May 6, 2019 08:19
15cdb98 to
bfb46bc
Compare
bagder
force-pushed
the
bagder/disable-more-features
branch
from
May 9, 2019 07:53
b54a97b to
6618efb
Compare
Member
Author
|
I'm having a hard time figuring out why the windows CI builds fail like this, so I'm more or less bisecting in the separate branch bagder/ci. I might then land some of the commits piecemeal instead once proven to pass the CI. |
bagder
force-pushed
the
bagder/disable-more-features
branch
from
May 13, 2019 06:38
6618efb to
07be034
Compare
Member
|
Ah, here is the PR I was looking for. Did you forget a "Closes" line? These are in master now and broke the HTTP-only AppVeyor tests. |
Member
Author
|
Only some of them are in master, the ones I (wrongly apparently) thought didn't break master... |
bagder
force-pushed
the
bagder/disable-more-features
branch
from
May 17, 2019 21:26
07be034 to
1aa1e50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch set that