Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of more features #3844

Closed
wants to merge 5 commits into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented May 5, 2019

This is a patch set that

  1. Makes the #ifdefs for features disable more code that isn't used
  2. Adds more defines to disable more specific features if desired (not all yet available via easy configure options)
  3. Adjusts tool code to be able to run with a libcurl built with features disabled
  4. The API/ABI is maintained but will return errors for disabled features.

@bagder
Copy link
Member Author

@bagder bagder commented May 5, 2019

Blah, silly me. It broke because it relies on something like #3846 so I'll get that fixed and landed first, then fixup this branch again and push a fix.

@bagder
Copy link
Member Author

@bagder bagder commented May 12, 2019

I'm having a hard time figuring out why the windows CI builds fail like this, so I'm more or less bisecting in the separate branch bagder/ci. I might then land some of the commits piecemeal instead once proven to pass the CI.

@bagder bagder force-pushed the bagder/disable-more-features branch from 6618efb to 07be034 Compare May 13, 2019
@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented May 14, 2019

Ah, here is the PR I was looking for. Did you forget a "Closes" line? These are in master now and broke the HTTP-only AppVeyor tests.

@bagder
Copy link
Member Author

@bagder bagder commented May 14, 2019

Only some of them are in master, the ones I (wrongly apparently) thought didn't break master...

@bagder bagder force-pushed the bagder/disable-more-features branch from 07be034 to 1aa1e50 Compare May 17, 2019
@bagder bagder closed this in 697b1f9 May 18, 2019
@bagder bagder deleted the bagder/disable-more-features branch May 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants