Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doh: disable DOH for when it doesn't work #3857

Closed
wants to merge 2 commits into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented May 9, 2019

Due to limitations in Curl_resolver_wait_resolv(), it doesn't work for
DOH resolves. This fix disables DOH for those.

Fixes #3850

Due to limitations in Curl_resolver_wait_resolv(), it doesn't work for
DOH resolves. This fix disables DOH for those.

Fixes #3850
@bagder
Copy link
Member Author

@bagder bagder commented May 9, 2019

This also highlights a limitation in the DOH resolver code that we should fix... The cases where Curl_resolver_wait_resolv() is called.

Loading

@bagder bagder closed this in 12d655d May 11, 2019
@bagder bagder deleted the bagder/disable-nonfunctioning-doh branch May 11, 2019
@jay
Copy link
Member

@jay jay commented May 13, 2019

This also highlights a limitation in the DOH resolver code that we should fix... The cases where Curl_resolver_wait_resolv() is called.

I still get memory leaks in Ubuntu after the merge if I use a variation of the reporter's config. Is that expected as a limitation or should I open a new issue?

dO:0
UR:0

Loading

@bagder
Copy link
Member Author

@bagder bagder commented May 13, 2019

Please open a new issue, it shouldn't happen!

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants