Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: Don't expose function definitions when components are disabled #3861

Closed
wants to merge 2 commits into from

Conversation

@captain-caveman2k
Copy link
Member

commented May 10, 2019

As per other header files. For example: http.h and http_ntlm.h.

There is no point in exposing the functions definitions unnecessarily when components are disabled.

This is more of a tidy up for consistency rather than to fix an actual (existing) issue. As the current code stands these header files would only cause a problem if a libcurl developer tried to a) include them in non HTTP code or b) use the HTTP negotiate functions from outside the negotiate code in http.c - prior to this commit this would cause a linker error rather than a compilation error as the function would be defined but not exist.

@jay

This comment has been minimized.

Copy link
Member

commented May 11, 2019

…abled
@captain-caveman2k captain-caveman2k force-pushed the captain-caveman2k:exposure branch from cd75716 to 5d7d0f8 May 11, 2019
@captain-caveman2k

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

Cheers @jay

It does beg the question, why is that clean up there?

It's only the HTTP digest clean up, and none of the other HTTP authentication mechanisms (NTLM and Negotiate for example) and non off the SASL clean up functions either.

@bagder

This comment has been minimized.

Copy link
Member

commented May 11, 2019

It fixed a bug! See 9caa3e2 (from #2272 fixed #2255)

@captain-caveman2k

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

Cheers @bagder

I wonder if that bug could potentially exists for the other mechanisms?

@bagder

This comment has been minimized.

Copy link
Member

commented May 11, 2019

Perhaps but we've had no such reports. Also, Digest is different than most of the other auth methods curl supports in that it has a state and yet survives connections so this bug can very well has been unique for Digest.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.