http: Don't expose function definitions when components are disabled #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One CI error seems legit |
captain-caveman2k
force-pushed
the
exposure
branch
from
cd75716
to
5d7d0f8
Compare
|
Cheers @jay It does beg the question, why is that clean up there? It's only the HTTP digest clean up, and none of the other HTTP authentication mechanisms (NTLM and Negotiate for example) and non off the SASL clean up functions either. |
|
Cheers @bagder I wonder if that bug could potentially exists for the other mechanisms? |
|
Perhaps but we've had no such reports. Also, Digest is different than most of the other auth methods curl supports in that it has a state and yet survives connections so this bug can very well has been unique for Digest. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As per other header files. For example: http.h and http_ntlm.h.
There is no point in exposing the functions definitions unnecessarily when components are disabled.
This is more of a tidy up for consistency rather than to fix an actual (existing) issue. As the current code stands these header files would only cause a problem if a libcurl developer tried to a) include them in non HTTP code or b) use the HTTP negotiate functions from outside the negotiate code in http.c - prior to this commit this would cause a linker error rather than a compilation error as the function would be defined but not exist.