Skip to content

Fix some Codacy warnings about redundant assignment - #3873

Closed
MarcelRaad wants to merge 3 commits into
curl:masterfrom
MarcelRaad:codacy_redundantassignment
Closed

Fix some Codacy warnings about redundant assignment#3873
MarcelRaad wants to merge 3 commits into
curl:masterfrom
MarcelRaad:codacy_redundantassignment

Conversation

@MarcelRaad

Copy link
Copy Markdown
Member

Remove a useless variable, narrow a variable scope, and initialize a variable with the correct value to fix them.

@MarcelRaad MarcelRaad changed the title Fix some Codacy warning about redundant assignment Fix some Codacy warnings about redundant assignment May 12, 2019
@MarcelRaad

Copy link
Copy Markdown
Member Author

The "new" Codacy warning is just from moved code.

Comment thread lib/ssh-libssh.c Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@MarcelRaad
MarcelRaad force-pushed the codacy_redundantassignment branch from 199c55a to 2670274 Compare May 13, 2019 07:37
sock was only used to be assigned to fd_read.

Closes curl#3873
This way, we need only one call to free.

Closes curl#3873
Just initialize word_begin with the correct value.

Closes curl#3873
@MarcelRaad
MarcelRaad force-pushed the codacy_redundantassignment branch from 2670274 to c57b8a2 Compare May 19, 2019 18:16
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request May 20, 2019
This way, we need only one call to free.

Closes curl#3873
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request May 20, 2019
Just initialize word_begin with the correct value.

Closes curl#3873
@MarcelRaad
MarcelRaad deleted the codacy_redundantassignment branch May 20, 2019 06:10
@lock lock Bot locked as resolved and limited conversation to collaborators Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

2 participants