Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_proxy: use the URL parser API #3878

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

commented May 12, 2019

As we treat a given proxy as a URL we should use the unified URL parser to extract the parts out of it.

This could also be used as a first step to fix #3482 since we now actually parse the zone ids in URLS since #3834 landed...

@bagder

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

The test 1447 failure should be addressed by merging #3880.

As we treat a given proxy as a URL we should use the unified URL parser
to extract the parts out of it.

Closes #3878
@bagder bagder force-pushed the bagder/parse-proxy-with-URL-parser branch from 6b9f3d4 to 395b3a0 May 14, 2019
@bagder bagder closed this in ee68bbe May 15, 2019
@bagder bagder deleted the bagder/parse-proxy-with-URL-parser branch May 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.