parse_proxy: use the URL parser API - #3878
Closed
bagder wants to merge 1 commit into
Closed
Conversation
Member
Author
|
The test 1447 failure should be addressed by merging #3880. |
As we treat a given proxy as a URL we should use the unified URL parser to extract the parts out of it. Closes #3878
bagder
force-pushed
the
bagder/parse-proxy-with-URL-parser
branch
from
May 14, 2019 11:51
6b9f3d4 to
395b3a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we treat a given proxy as a URL we should use the unified URL parser to extract the parts out of it.
This could also be used as a first step to fix #3482 since we now actually parse the zone ids in URLS since #3834 landed...