Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl_udpateconninfo: mark variable unused when compiled without features #3910

Closed

Conversation

Projects
None yet
3 participants
@danielgustafsson
Copy link
Member

commented May 20, 2019

When compiling without getpeername() or getsockname(), the sockfd parameter to Curl_udpateconninfo() became unused after commit e91e481 added ifdef guards.

Reported in autobuild https://curl.haxx.se/dev/log.cgi?id=20190520172441-32196

udpateconninfo: mark variable unused
When compiling without getpeername() or getsockname(), the sockfd
paramter to Curl_udpateconninfo() became unused after commit e91e481
added ifdef guards.

Closes #xxxx
Autobuild https://curl.haxx.se/dev/log.cgi?id=20190520172441-32196
@bagder

This comment has been minimized.

Copy link
Member

commented May 20, 2019

This fix looks fine.

The greater question might however be why @mback2k's build there fails to find getpeername and getsockname when they seem to be provided by winsock and should be found and used... ?

@danielgustafsson

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

The greater question might however be why @mback2k's build there fails to find getpeername and getsockname when they seem to be provided by winsock and should be found and used... ?

Thats a good question, I have no idea and no testsystem to investigate on.

@danielgustafsson

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

Opened issue #3913 to track why the functions were not identified for usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.