http_ntlm: Remove duplicate NSS initialisation #3935
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captain-caveman2k
force-pushed
the
nss
branch
3 times, most recently
from
476fa9b to
6c174bc
Compare
|
Please save this until after the release, I don't know that it will break anything but why risk it. |
|
I agree that compilation errors need to be fixed. In any case, calling |
captain-caveman2k
force-pushed
the
nss
branch
2 times, most recently
from
680724c to
fb66c62
Compare
captain-caveman2k
force-pushed
the
nss
branch
from
fb66c62 to
b6a5085
Compare
kdudka
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
As I understand it, the code was made redundant by commit 33be9e2.
Assuming Curl_auth_decode_ntlm_type2_message() is always called before any NSS crypto is used on the way from Curl_output_ntlm(), the code should be safe to remove. But, to be honest, I do not know how NTLM works exactly.
If NTLM tests pass with libcurl-linked libcurl, this change is good to go in from my point of view.
captain-caveman2k
force-pushed
the
nss
branch
from
b6a5085 to
d357dc9
Compare
kdudka
approved these changes
Oct 16, 2019
Given that this is performed by the NTLM code there is no need to perform the initialisation in the HTTP layer. This also keeps the initialisation the same as the SASL based protocols and also fixes a possible compilation issue if both NSS and SSPI were to be used as multiple SSL backends.
captain-caveman2k
force-pushed
the
nss
branch
from
d357dc9 to
e696c35
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that this is performed by the NTLM code there is no need to
perform the initialisation in the HTTP layer. This also keeps the
initialisation the same as the SASL based protocols and also fixes a
possible compilation issue if both NSS and SSPI were to be used as
multiple SSL backends.