Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upcurl-win32.h: Enable Unix Domain Sockets based on the Window SDK version #3939
Conversation
This comment has been minimized.
This comment has been minimized.
Yes, as the feature is not compiler-dependent, I'd rather remove the existing check. sdkddkver.h has always been there and only winsdkver.h has been introduced in a Windows SDK later than the lowest one we support, right? I always confuse these headers. |
This comment has been minimized.
This comment has been minimized.
Yes that was pretty much view as well.
I've only got the latest SDK's installed on my home workstation and laptop, but here I have v5.0, v7.0, v7.0A, etc... Both are present in v7.0+ but not v5.0. As such I think we can use WINVER / _WIN32_WINNT to include sdkddkver.h - I will play about with that tonight. |
captain-caveman2k
force-pushed the
captain-caveman2k:win_domain_sockets
branch
from
a380796
to
2a2b8fc
May 24, 2019
MarcelRaad
reviewed
May 25, 2019
| #if defined(_MSC_VER) && _MSC_VER >= 1900 | ||
| /* #define USE_UNIX_SOCKETS */ | ||
| #if defined(_MSC_VER) && (_MSC_VER >= 1500) | ||
| /* sdlddkver.h first shipped with Platform SDK v6.0A included with VS2008 */ |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Coveralls is silly again. |
captain-caveman2k
force-pushed the
captain-caveman2k:win_domain_sockets
branch
from
2a2b8fc
to
83c86af
May 27, 2019
captain-caveman2k
changed the title
curl-win32.h: Automatically enable Unix Domain Sockets based on the Window SDK version
curl-win32.h: Enable Unix Domain Sockets based on the Window SDK version
May 28, 2019
captain-caveman2k
closed this
in
28526e9
May 28, 2019
captain-caveman2k
deleted the
captain-caveman2k:win_domain_sockets
branch
May 31, 2019
php-pulls
pushed a commit
to php/php-src
that referenced
this pull request
Jun 6, 2019
captain-caveman2k commentedMay 24, 2019
•
edited
Microsoft added support for Unix Domain Sockets in Windows 10 1803 (RS4).
Rather than expect the user to enable Unix Domain Sockets by uncommenting the #define that was added in 0fd6221 we use the RS4 pre-processor variable that is present in newer versions of the Windows SDK.