Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: have runtests figure out disabled features #3950

Closed
wants to merge 2 commits into from

Conversation

@bagder
Copy link
Member

commented May 27, 2019

... so that runtests can skip individual test cases that test features
that are explicitly disabled in this build. This new logic is intended
for disabled features that aren't otherwise easily visible through the
curl_version_info() or other API calls.

tests/server/disabled is a newly built executable that will output a
list of disabled features. Outputs nothing for a default build.

tests: have runtests figure out disabled features
... so that runtests can skip individual test cases that test features
that are explictiyl disabled in this build. This new logic is intended
for disabled features that aren't otherwise easily visible through the
curl_version_info() or other API calls.

tests/server/disabled is a newly built executable that will output a
list of disabled features. Outputs nothing for a default build.

@bagder bagder added the tests label May 27, 2019

"* $curl\n",
"* $libcurl\n",
"* Features: $feat\n",
"* Disabled: $dis\n",

This comment has been minimized.

Copy link
@danielgustafsson

danielgustafsson May 28, 2019

Member

This can be used uninitialized according to the buildfarm: https://curl.haxx.se/dev/log.cgi?id=20190527165744-10382#prob1

This comment has been minimized.

Copy link
@bagder

bagder May 28, 2019

Author Member

@dago how come these builds run on PR branch like this? The autobuilds are supposed to run on master... In this case of course it turned out useful since the solaris builds in the CI didn't spot this problem but the autobuilds one did!

This comment has been minimized.

Copy link
@dago

dago Jun 19, 2019

Contributor

@bagder The builds are actually triggered by the GitHub hook and that one seems to be configured to pick up pull requests too. I vaguely remember I changed this from separate triggers (one poll, one trigger) to make the code easier and this looks like an artifact from that. Is the current configuration acceptable? It should be possible to set up a branch filter for autobuilds if needed.

@bagder bagder closed this in 40259ca Jun 17, 2019

@bagder bagder deleted the bagder/test-when-disabled branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.