tests: have runtests figure out disabled features #3950
Closed
Conversation
... so that runtests can skip individual test cases that test features that are explictiyl disabled in this build. This new logic is intended for disabled features that aren't otherwise easily visible through the curl_version_info() or other API calls. tests/server/disabled is a newly built executable that will output a list of disabled features. Outputs nothing for a default build.
| "* $curl\n", | ||
| "* $libcurl\n", | ||
| "* Features: $feat\n", | ||
| "* Disabled: $dis\n", |
danielgustafsson
May 28, 2019
Member
This can be used uninitialized according to the buildfarm: https://curl.haxx.se/dev/log.cgi?id=20190527165744-10382#prob1
This can be used uninitialized according to the buildfarm: https://curl.haxx.se/dev/log.cgi?id=20190527165744-10382#prob1
bagder
May 28, 2019
Author
Member
@dago how come these builds run on PR branch like this? The autobuilds are supposed to run on master... In this case of course it turned out useful since the solaris builds in the CI didn't spot this problem but the autobuilds one did!
@dago how come these builds run on PR branch like this? The autobuilds are supposed to run on master... In this case of course it turned out useful since the solaris builds in the CI didn't spot this problem but the autobuilds one did!
dago
Jun 19, 2019
Contributor
@bagder The builds are actually triggered by the GitHub hook and that one seems to be configured to pick up pull requests too. I vaguely remember I changed this from separate triggers (one poll, one trigger) to make the code easier and this looks like an artifact from that. Is the current configuration acceptable? It should be possible to set up a branch filter for autobuilds if needed.
@bagder The builds are actually triggered by the GitHub hook and that one seems to be configured to pick up pull requests too. I vaguely remember I changed this from separate triggers (one poll, one trigger) to make the code easier and this looks like an artifact from that. Is the current configuration acceptable? It should be possible to set up a branch filter for autobuilds if needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
... so that runtests can skip individual test cases that test features
that are explicitly disabled in this build. This new logic is intended
for disabled features that aren't otherwise easily visible through the
curl_version_info() or other API calls.
tests/server/disabled is a newly built executable that will output a
list of disabled features. Outputs nothing for a default build.