Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conncache: Remove the DEBUGASSERT on length check #3962

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@captain-caveman2k
Copy link
Member

commented May 29, 2019

We trust the calling code as this is an internal function.

@bagder

This comment has been minimized.

Copy link
Member

commented May 29, 2019

If we remove this, then I think the '128' value used for the buffer in two places should be changed to a define like HASKEY_SIZE instead to make it more obvious it's not a choice to use whatever value you like.

conncache: Remove DEBUGASSET on length check
We trust the calling code as this is an internal function.

@captain-caveman2k captain-caveman2k force-pushed the captain-caveman2k:seg_fault.1 branch from 018b1d2 to e5077a8 May 29, 2019

@captain-caveman2k captain-caveman2k changed the title conncache: Remove DEBUGASSET on length check conncache: Remove DEBUGASSERT on length check May 29, 2019

@bagder

bagder approved these changes May 29, 2019

@captain-caveman2k captain-caveman2k changed the title conncache: Remove DEBUGASSERT on length check conncache: Remove the DEBUGASSERT on length check May 29, 2019

@captain-caveman2k captain-caveman2k deleted the captain-caveman2k:seg_fault.1 branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.