tool_cb_prg: Fix integer overflow in progress bar #3984
Closed
Conversation
Commit 61faa0b fixed the progress bar width calculation to avoid integer overflow, but failed to account for the fact that initial_size is initialized to -1 causing another signed integer overflow. Fix by separately checking for this case before the width calculation. Closes #xxxx Reported-by: Brian Carpenter (Geeknik Labs)
Maybe add a comment on why/how it can be less than zero at this point? |
AFAICT it's only set to -1 to signal resuming an upload and that only works with FTP (and SSH) where libcurl gets the file size of the remote file and then resumes the upload from that position. Lines 747 to 748 in 69248b5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Commit 61faa0b fixed the progress bar width calculation to avoid integer overflow, but failed to account for the fact that initial_size is initialized to -1 causing another signed integer overflow. Fix by separately checking for this case before the width calculation.
Closes #xxxx
Reported-by: Brian Carpenter (Geeknik Labs)