added Windows SSL support for CMake build #399

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@snikulov
Member

Re-enabled Windows SSL support for CMake build.

Tested with MSVC 2013/2015, MinGW 5.1.0.

c:\WORK\GitHub\curl\mingw\src>curl --version
curl 7.45.0-DEV (Windows) libcurl/7.45.0-DEV WinSSL
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp smtp smtps telnet tftp
Features: SSPI Kerberos SPNEGO NTLM SSL

@snikulov
Member

@bradking Could you please review and comment? Thank you.

@bradking
Contributor

Good start. If HAVE_SCHANNEL_H succeeds but HAVE_SSPI_H fails then one will get compilation errors with the current logic. We cannot allow the configured header to define USE_SCHANNEL but not USE_WINDOWS_SSPI. Please update the logic accordingly.

Style nit: the CMakeLists.txt file currently uses 2-space indentation but the patch adds a block using 4-space indentation.

@snikulov
Member

@bradking fixed both comments 5d1581c4b89b8b334de9dad5883e91ef57d88441

@bradking
Contributor

LGTM. Please squash down to one commit.

@snikulov
Member

@bradking Done.
@bagder Could you please review and merge?
Thank you.

@bagder bagder added a commit that closed this pull request Aug 25, 2015
@snikulov @bagder snikulov + bagder cmake: added Windows SSL support
Closes #399
2132708
@bagder bagder closed this in 2132708 Aug 25, 2015
@jgsogo jgsogo added a commit to jgsogo/curl that referenced this pull request Oct 19, 2015
@snikulov @jgsogo snikulov + jgsogo cmake: added Windows SSL support
Closes #399
05c146e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment