Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CURLOPT_MAXAGE_CONN time comparison #4013

Closed

Conversation

@cliffcrosland
Copy link
Contributor

commented Jun 11, 2019

Old connections are meant to expire from the connection cache after
CURLOPT_MAXAGE_CONN seconds. However, they actually expire after 1000x
that value. This occurs because a time value measured in milliseconds is
accidentally divided by 1M instead of by 1,000.

Test case: https://gist.github.com/cliffcrosland/bd1681f06de12e1c9489eac5632e444a

Fix CURLOPT_MAXAGE_CONN time comparison
Old connections are meant to expire from the connection cache after
CURLOPT_MAXAGE_CONN seconds. However, they actually expire after 1000x
that value. This occurs because a time value measured in milliseconds is
accidentally divided by 1M instead of by 1,000.
@bagder

bagder approved these changes Jun 11, 2019

@bagder bagder self-assigned this Jun 11, 2019

@jay jay closed this in f67009d Jun 12, 2019

@jay

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Thanks.

(@bagder I missed that you self-assigned this, didn't mean to step on your toes)

@bagder

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

No problems, this is even better as I didn't have to do anything! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.