Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--disable-progress-meter #4023

Closed
wants to merge 4 commits into from
Closed

--disable-progress-meter #4023

wants to merge 4 commits into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Jun 13, 2019

Here's a new take at allowing a build to disable the progress meter. The previous attempt was reverted in #3928 due to regressions.

My plan is to take the bug report from #3927 and make a test case out of it to verify that this PR doesn't break existing functionality (in the same way) before I merge.

bagder added 4 commits Feb 11, 2019
@bagder bagder force-pushed the bagder/disable-progress-meter branch from 0d66782 to 1189269 Jun 14, 2019
@bagder bagder closed this in 21080e1 Jun 18, 2019
@bagder bagder deleted the bagder/disable-progress-meter branch Jun 18, 2019
@jay
Copy link
Member

@jay jay commented Jun 18, 2019

Why is a compile-time option needed to disable the progress meter?

@bagder
Copy link
Member Author

@bagder bagder commented Jun 18, 2019

It completely removes the support for the progress meter from the build.

@jay
Copy link
Member

@jay jay commented Jun 18, 2019

Yeah but why, did you do it for size?

@bagder
Copy link
Member Author

@bagder bagder commented Jun 18, 2019

Yes.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.