Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtests: report single test time + total duration #4027

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

commented Jun 14, 2019

... after each successful test.

runtests: report single test time + total duration
... after each successful test.
@cmeister2

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

Interesting results. Should valgrind be running on most variants? It would appear to add ~10 minutes to the test time.

@MarcelRaad

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

The problem with Valgrind is: Valgrind + OpenSSL + Xenial makes Valgrind crash because of an assertion failure.

@cmeister2

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

@MarcelRaad I actually meant the negative; should valgrind be disabled on all but a "maximal" build, so that CI finishes more quickly in general?

@bagder

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

The challange is with all the various build combinations and making sure they all have at least one build that runs with valgrind enabled. Ie there cannot be just one "maximal" build since there are so many alternative options and mutually exclusive ones. But yes, switching off valgrind for the builds that make sense will certainly make them run faster!

@bagder

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

I like the new timing information output like this! I'll let the PR sit here a while to collect input from others if someone has objections, but if nobody does I'll merge it later.

@bagder bagder closed this in c97e849 Jun 15, 2019

@bagder bagder deleted the bagder/runtests-duration branch Jun 15, 2019

@dfandrich

This comment has been minimized.

Copy link
Collaborator

commented Jun 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.