Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nmake install prefix #4031

Closed
wants to merge 2 commits into from

Conversation

@eiszapfen2000
Copy link
Contributor

commented Jun 16, 2019

Add WITH_PREFIX flag to the nmake based build to allow for a custom install directory.
Please add rdw@steadingsoftware.com as reviewer.

Thanks,
Thomas

@rodwiddowson

This comment has been minimized.

Copy link
Contributor

commented Jun 16, 2019

@eiszapfen2000 I'll try and get a build done from this during the week. Thanks !

@bagder

This comment has been minimized.

Copy link
Member

commented Jun 16, 2019

Coveralls is just being silly, ignore that.

@bagder

bagder approved these changes Jun 16, 2019

@rodwiddowson

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

I Just noticed winbuild\BUILD_WINDOWS.txt which I suppose needs changed, but this is an edge build case so full documentation migth be irrelevant? dunno

Anyway I just did a build from this PR and (to noone's great surprise, I'm sure) I could build just fine

@bagder bagder closed this in 672ff59 Jun 17, 2019

@bagder

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Thanks! I added a small blurb to BUILD_WINDOWS.txt and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.