Skip to content

/curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: remove outdated comment #4033

Closed
wants to merge 1 commit into from

Conversation

@danielgustafsson
Copy link
Member

commented Jun 17, 2019 •
edited

OpenSSL used to call exit(1) on syntax errors in OPENSSL_config(), which is why we switched to CONF_modules_load_file() and introduced a comment stating why. This behavior was however changed in OpenSSL commit abdd677125f3a9e3082f8c5692203590fdb9b860, so remove the now outdated and incorrect comment. The mentioned commit also declares OPENSSL_config() deprecated so keep the current coding.

Also re-indent an adjacent comment to something which seems saner.
@danielgustafsson
openssl: remove outdated comment 
OpenSSL used to call exit(1) on syntax errors in OPENSSL_config(),
which is why we switched to CONF_modules_load_file() and introduced
a comment stating why. This behavior was however changed in OpenSSL
commit abdd677125f3a9e3082f8c5692203590fdb9b860, so remove the now
outdated and incorrect comment. The mentioned commit also declares
OPENSSL_config() deprecated so keep the current coding.

Closes #xxxx
Loading status checks…
47501ea
@bagder

bagder approved these changes Jun 17, 2019
View changes

@danielgustafsson danielgustafsson closed this in 03a22a2 Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@danielgustafsson @bagder
You can’t perform that action at this time.