Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport non-localhost HOSTIP for dict/smb servers #4048
Conversation
bagder
approved these changes
Jun 20, 2019
This comment has been minimized.
This comment has been minimized.
|
The Coveralls numbers are bananas again, ignore them. |
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
bagder
closed this
in
2aff76c
Jun 20, 2019
foopoiuyt
deleted the
foopoiuyt:test_server_hostip
branch
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
foopoiuyt commentedJun 19, 2019
smbserver.py/dictserver.py were explicitly using localhost/127.0.0.1
for binding the server which when we were running the tests with
a separate HOSTIP and CLIENTIP had failures verifying the server
from the device we were testing.
This changes them to take the address on the command line from
runtests.py and default to localhost/127.0.0.1 if none is given.