Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-localhost HOSTIP for dict/smb servers #4048

Closed
wants to merge 1 commit into from

Conversation

@foopoiuyt
Copy link

foopoiuyt commented Jun 19, 2019

smbserver.py/dictserver.py were explicitly using localhost/127.0.0.1
for binding the server which when we were running the tests with
a separate HOSTIP and CLIENTIP had failures verifying the server
from the device we were testing.

This changes them to take the address on the command line from
runtests.py and default to localhost/127.0.0.1 if none is given.

smbserver.py/dictserver.py were explicitly using localhost/127.0.0.1
for binding the server which when we were running the tests with
a separate HOSTIP and CLIENTIP had failures verifying the server
from the device we were testing.

This changes them to take the address from runtests.py and default
to localhost/127.0.0.1 if none is given.
@bagder
bagder approved these changes Jun 20, 2019
@bagder

This comment has been minimized.

Copy link
Member

bagder commented Jun 20, 2019

The Coveralls numbers are bananas again, ignore them.

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Jun 20, 2019

Thanks!

@bagder bagder closed this in 2aff76c Jun 20, 2019
@foopoiuyt foopoiuyt deleted the foopoiuyt:test_server_hostip branch Jun 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.