Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typecheck: add 3 missing strings and a callback data pointer #4050

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

commented Jun 20, 2019

No description provided.

@@ -362,7 +365,7 @@ _CURL_WARNING(_curl_easy_getinfo_err_curl_off_t,
(option) == CURLOPT_SSL_CTX_DATA || \
(option) == CURLOPT_WRITEDATA || \
(option) == CURLOPT_RESOLVER_START_DATA || \
(option) == CURLOPT_CURLU || \

This comment has been minimized.

Copy link
@MarcelRaad

MarcelRaad Jun 20, 2019

Member

What's with this option now? Did you remove it on purpose?

This comment has been minimized.

Copy link
@bagder

bagder Jun 20, 2019

Author Member

I hesitated on how to deal with it. The macro there is specifically said to be for pointer arguments to callbacks so CURLOPT_CURLU was wrongly put there to begin with, even if it also takes a pointer. This rights that wrong. Not sure it makes any particular difference for anyone.

@bagder bagder closed this in bd4390b Jun 21, 2019

@bagder bagder deleted the bagder/typecheck-strings-data branch Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.