Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisestypecheck: add 3 missing strings and a callback data pointer #4050
Conversation
| @@ -362,7 +365,7 @@ _CURL_WARNING(_curl_easy_getinfo_err_curl_off_t, | |||
| (option) == CURLOPT_SSL_CTX_DATA || \ | |||
| (option) == CURLOPT_WRITEDATA || \ | |||
| (option) == CURLOPT_RESOLVER_START_DATA || \ | |||
| (option) == CURLOPT_CURLU || \ | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bagder
Jun 20, 2019
Author
Member
I hesitated on how to deal with it. The macro there is specifically said to be for pointer arguments to callbacks so CURLOPT_CURLU was wrongly put there to begin with, even if it also takes a pointer. This rights that wrong. Not sure it makes any particular difference for anyone.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bagder commentedJun 20, 2019
No description provided.