Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uptypecheck: add 3 missing strings and a callback data pointer #4050
Conversation
MarcelRaad
approved these changes
Jun 20, 2019
MarcelRaad
reviewed
Jun 20, 2019
| @@ -362,7 +365,7 @@ _CURL_WARNING(_curl_easy_getinfo_err_curl_off_t, | |||
| (option) == CURLOPT_SSL_CTX_DATA || \ | |||
| (option) == CURLOPT_WRITEDATA || \ | |||
| (option) == CURLOPT_RESOLVER_START_DATA || \ | |||
| (option) == CURLOPT_CURLU || \ | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bagder
Jun 20, 2019
Author
Member
I hesitated on how to deal with it. The macro there is specifically said to be for pointer arguments to callbacks so CURLOPT_CURLU was wrongly put there to begin with, even if it also takes a pointer. This rights that wrong. Not sure it makes any particular difference for anyone.
bagder
closed this
in
bd4390b
Jun 21, 2019
bagder
deleted the
bagder/typecheck-strings-data
branch
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bagder commentedJun 20, 2019
No description provided.