Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: call done_sending on end of upload #4068

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

bagder commented Jun 24, 2019

To make sure a HTTP/2 stream registers the end of stream.

Reported-by: Tom van der Woerdt
Fixes #4043

To make sure a HTTP/2 stream registers the end of stream.

Reported-by: Tom van der Woerdt
Fixes #4043
@TvdW

This comment has been minimized.

Copy link

TvdW commented Jun 24, 2019

No luck... this probably fixes a different bug than I'm seeing

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Jun 24, 2019

I was a bit afraid of that. I get a 405 immediately from my test server when I send the POST and a very short response. The 405 usually aborts the sending of the data so for a 200 post the code path is probably a little different.

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Jun 24, 2019

I fixed my server config to return 200 for POSTs, and I tried with 13 bytes responses, 4KB responses and 17MB responses. I can't seem to reproduce this problem. 😞

@bagder bagder closed this in 265f7f4 Jun 24, 2019
@bagder bagder deleted the bagder/h2-send-done branch Jun 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.