Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix outdated string suggesting HTTP/2 is not the default #4075

Closed
wants to merge 1 commit into from

Conversation

@nh2
Copy link
Contributor

commented Jun 25, 2019

Commit 25fd105
made HTTP2 the default, and further down in the man page that new default
is mentioned, but the section at the top contradicted it until now.

This caused some confusion with libcurl users, for example in NixOS/nix#2971.

@nh2 nh2 referenced this pull request Jun 25, 2019

Closed

Cannot disable http2 #2971

@bagder

bagder approved these changes Jun 25, 2019

Show resolved Hide resolved docs/libcurl/opts/CURLOPT_HTTP_VERSION.3 Outdated
docs: Fix outdated string suggesting HTTP/2 is not the default
Commit 25fd105
made HTTP2 the default, and further down in the man page that new default
is mentioned, but the section at the top contradicted it until now.

Also remove claim that setting the HTTP version is not sensible.

@nh2 nh2 force-pushed the nh2:patch-1 branch from 411b6b1 to 00b888b Jun 25, 2019

@bagder

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

Thanks!

@bagder bagder closed this in 8dd041b Jun 25, 2019

@nh2

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2019

Thanks!

@aniketd
Copy link

left a comment

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.