New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake // IPv6 // disable Unix header check on Windows platform #409

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@snikulov
Member

snikulov commented Sep 3, 2015

Hello All!

I've removed "netinet/in.h" header check on Windows platform, since it absent.
Current check always failed leaving IPv6 support disabled in result build.

Build tested with MSVC++ 2013/MinGW gcc 5.1

@bradking could you please review?

Thank you.

@bagder bagder added the build label Sep 3, 2015

@snikulov

This comment has been minimized.

Member

snikulov commented Sep 7, 2015

@bradking do you have some time to take a look on change? Thank you!

@bradking

This comment has been minimized.

Contributor

bradking commented Sep 8, 2015

Yes, LGTM.

Sorry for the delay, I've been out of the office.

@bagder bagder closed this in 1b8a5af Sep 8, 2015

jgsogo added a commit to jgsogo/curl that referenced this pull request Oct 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment