cmake // IPv6 // disable Unix header check on Windows platform#409
Closed
snikulov wants to merge 1 commit intocurl:masterfrom
Closed
cmake // IPv6 // disable Unix header check on Windows platform#409snikulov wants to merge 1 commit intocurl:masterfrom
snikulov wants to merge 1 commit intocurl:masterfrom
Conversation
Contributor
Author
|
@bradking do you have some time to take a look on change? Thank you! |
Contributor
|
Yes, LGTM. Sorry for the delay, I've been out of the office. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello All!
I've removed "netinet/in.h" header check on Windows platform, since it absent.
Current check always failed leaving IPv6 support disabled in result build.
Build tested with MSVC++ 2013/MinGW gcc 5.1
@bradking could you please review?
Thank you.